lxd-ui: run nixosTests.lxd.ui by default#281091
Merged
adamcstephens merged 1 commit intoNixOS:masterfrom Jan 15, 2024
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
adamcstephens
requested changes
Jan 15, 2024
Contributor
adamcstephens
left a comment
adamcstephens
left a comment
There was a problem hiding this comment.
You need to add nixosTests to the argument attrset at the top.
error: undefined variable 'nixosTests'
Member
Author
|
Oops, fixed! |
adamcstephens
approved these changes
Jan 15, 2024
Contributor
adamcstephens
left a comment
adamcstephens
left a comment
There was a problem hiding this comment.
Looks good to me. Test ran successfully on x86_64-linux. Will wait for ofborg before merging.
delroth
added
the
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Ensure tests are run for LXD UI when building
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.