Skip to content

python3Packages.cmdstanpy: relax dependency, drop legacy builder#280777

Merged
natsukium merged 1 commit intoNixOS:masterfrom
TomaSajt:cmdstanpy
Jan 14, 2024
Merged

python3Packages.cmdstanpy: relax dependency, drop legacy builder#280777
natsukium merged 1 commit intoNixOS:masterfrom
TomaSajt:cmdstanpy

Conversation

@TomaSajt
Copy link
Contributor

Description of changes

Closes #280751

This PR relaxes the acceptable version range for the stanio dependency of cmdstanpy
I also made it use the new pyproject = true builder. Only with this new builder did it actually complain about the version range. Weird.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 13, 2024
@fabaff
Copy link
Member

fabaff commented Jan 13, 2024

Result of nixpkgs-review pr 280777 run on x86_64-linux 1

4 packages built:
  • python311Packages.cmdstanpy
  • python311Packages.cmdstanpy.dist
  • python311Packages.prophet
  • python311Packages.prophet.dist

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 13, 2024
@natsukium
Copy link
Member

@ofborg build python311Packages.cmdstanpy

@natsukium
Copy link
Member

Only with this new builder did it actually complain about the version range.

Probably because python-updates reintroduced version checking.

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@natsukium natsukium merged commit abde03c into NixOS:master Jan 14, 2024
@TomaSajt TomaSajt deleted the cmdstanpy branch June 19, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: python3Packages.prophet

3 participants