Skip to content

Comments

pict-rs: 0.4.7 -> 0.5.0#280221

Merged
happysalada merged 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/pict-rs
Jan 14, 2024
Merged

pict-rs: 0.4.7 -> 0.5.0#280221
happysalada merged 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/pict-rs

Conversation

@r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/pict-rs/versions.

meta.description for pict-rs is: A simple image hosting service

meta.homepage for pict-rs is: https://git.asonix.dog/asonix/pict-rs

Updates performed
  • Rust version update
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 0.5.0 with grep in /nix/store/wd0ycysni7c7lakqj90vi8n2b15h8h9z-pict-rs-0.5.0
  • found 0.5.0 in filename of file in /nix/store/wd0ycysni7c7lakqj90vi8n2b15h8h9z-pict-rs-0.5.0

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
pict-rs
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/wd0ycysni7c7lakqj90vi8n2b15h8h9z-pict-rs-0.5.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A pict-rs https://github.com/r-ryantm/nixpkgs/archive/d8404b6c2ee20a5947398625bcae19e64c14f526.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/d8404b6c2ee20a5947398625bcae19e64c14f526#pict-rs

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/wd0ycysni7c7lakqj90vi8n2b15h8h9z-pict-rs-0.5.0
ls -la /nix/store/wd0ycysni7c7lakqj90vi8n2b15h8h9z-pict-rs-0.5.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • pict-rs

Maintainer pings

cc @happysalada for testing.

@ofborg ofborg bot requested a review from happysalada January 11, 2024 09:41
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 11, 2024
@happysalada
Copy link
Contributor

Result of nixpkgs-review pr 280221 run on x86_64-linux 1

1 package built:
  • pict-rs

@happysalada
Copy link
Contributor

@adisbladis @zowoq @K900 the upgrade of this dependency should be transparent to lemmy https://git.asonix.dog/asonix/pict-rs/releases/tag/v0.5.0
however if anyone running this service has time to test, that will be nice.

@happysalada happysalada merged commit ca6f516 into NixOS:master Jan 14, 2024
@r-ryantm r-ryantm deleted the auto-update/pict-rs branch January 14, 2024 20:06
@asonix
Copy link
Contributor

asonix commented Feb 17, 2024

Just noticed that pict-rs is now 0.5 in nixpkgs (i'm the pict-rs developer)

to be consistent I think there should still be a pict-rs 0.4 package, just like there exists a pict-rs 0.3 package. pict-rs only maintains a migration path from the previous version, so 0.3 can migrate to 0.4, and 0.4 can migrate to 0.5, but 0.3 can't migrate directly to 0.5. Providing only 0.3 and 0.5 without an 0.4 option will strand users on 0.3 if they haven't yet upgraded.

@happysalada
Copy link
Contributor

Hey thank you for coming by!
nixpkgs doesn't provide multiple versions for packages usually, some exceptions are made but they are usually for very big packages.
I'm happy to add something in the release notes about users needing to upgrade to 0.4 to not be left stranded.
pict_rs 0.3 should be removed ideally.
I have to say I don't have a lot of time at the moment to maintain this, and so I have made a less than ideal job most likely.
I've pinged a few people that are using this through lemmy when the 0.5 upgrade was made for testing and no one complained. Most likely they were just busy and haven't made the upgrade.

@emilazy emilazy mentioned this pull request Aug 20, 2024
13 tasks
emilazy added a commit to emilazy/nixpkgs that referenced this pull request Aug 22, 2024
This was broken by the Rust 1.80 upgrade, and is an old version that
we’d have to patch to keep working.

We have already done the 0.4 → 0.5 update without keeping around
the old version or adding in any additional `stateVersion` logic
in <NixOS#280221>. As a result,
migration for 0.3 users is going to be a little awkward. I’ve done
my best to provide comprehensive instructions for anyone who hasn’t
already bumped to 0.4.

It is probably a footgun to add `stateVersion` logic for any
package that makes backwards‐incompatible schema changes and only
supports migration from the immediately previous version. Users
won’t get migrated by default and we have to either package and
maintain an endlessly growing list of old versions or add complicated
instructions like this. It’s not really practical for us to support
a significantly better migration story than upstream does.
RCoeurjoly pushed a commit to RCoeurjoly/nixpkgs that referenced this pull request Aug 23, 2024
This was broken by the Rust 1.80 upgrade, and is an old version that
we’d have to patch to keep working.

We have already done the 0.4 → 0.5 update without keeping around
the old version or adding in any additional `stateVersion` logic
in <NixOS#280221>. As a result,
migration for 0.3 users is going to be a little awkward. I’ve done
my best to provide comprehensive instructions for anyone who hasn’t
already bumped to 0.4.

It is probably a footgun to add `stateVersion` logic for any
package that makes backwards‐incompatible schema changes and only
supports migration from the immediately previous version. Users
won’t get migrated by default and we have to either package and
maintain an endlessly growing list of old versions or add complicated
instructions like this. It’s not really practical for us to support
a significantly better migration story than upstream does.
greg-hellings pushed a commit to greg-hellings/nixpkgs that referenced this pull request Aug 24, 2024
This was broken by the Rust 1.80 upgrade, and is an old version that
we’d have to patch to keep working.

We have already done the 0.4 → 0.5 update without keeping around
the old version or adding in any additional `stateVersion` logic
in <NixOS#280221>. As a result,
migration for 0.3 users is going to be a little awkward. I’ve done
my best to provide comprehensive instructions for anyone who hasn’t
already bumped to 0.4.

It is probably a footgun to add `stateVersion` logic for any
package that makes backwards‐incompatible schema changes and only
supports migration from the immediately previous version. Users
won’t get migrated by default and we have to either package and
maintain an endlessly growing list of old versions or add complicated
instructions like this. It’s not really practical for us to support
a significantly better migration story than upstream does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants