readline: Support building for Windows with MinGW#280099
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Jan 10, 2024
Merged
readline: Support building for Windows with MinGW#280099Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
This commit is specifically designed to avoid a mass rebuild. I'll make a follow-up PR to staging which will make the patches unconditional, etc. Co-Authored-By: Weijia Wang <9713184+wegank@users.noreply.github.com>
Ericson2314
added a commit
to obsidiansystems/nixpkgs
that referenced
this pull request
Jan 10, 2024
We clean up NixOS#280099 by making the the mingw patches unconditional, using the slight modifications to one patch in msys2/MINGW-packages#19701 to do so. This is a separate commit so so NixOS#280099 can go to master right away.
13 tasks
ofborg
bot
added
10.rebuild-darwin: 0
wegank
approved these changes
Jan 10, 2024
delroth
added
the
12.approvals: 1
Contributor
|
Successfully created backport PR for |
1 task
Contributor
|
Git push to origin failed for release-23.11 with exitcode 1 |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit is specifically designed to avoid a mass rebuild. I'll make a follow-up PR to staging which will make the patches unconditional, etc.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.