Conversation
bachp
left a comment
There was a problem hiding this comment.
@slam-bert Thanks for the contribution. Two remarks from my side:
Could you sqash your two commits into one and also use rmg: init at 0.5.4 as the commit message.
Also just adding a default.nix for the package to where you added it doesn't make it available in nixpkgs. You either have to make an entry in all-packages.nix. Or even better move it to the by-name hirarchy. This is quite new and there is is enough to just add it as you did. Check the README for where exactly to put it.
|
Hello @bachp! I wasn't able to squash the commits (much to my frustration), so I instead decided to rollback my fork to before the commits and create a new commit. I made sure to move the EDIT: I've also updated the If any other changes are needed, please let me know! |
|
@slam-bert I forgot that in the by-name tree the file needs to be named |
|
@bachp Thanks for bringing that to my attention! I renamed |
235849f to
42e0c19
Compare
7c18357 to
37f3999
Compare
rmg: append to init at 0.5.4 rmg: further add to init at 0.5.4 rmg: (hopefully) finally finish init at 0.5.4 rmg: fix qt imports for init at 0.5.4 rmg: move 'which' to nativeBuildInputs for init at 0.5.4 rmg: try only importing 'which' in init at 0.5.4 rmg: fix a whitespace error in init at 0.5.4 rmg: remove 'dash' for init at 0.5.4 rmg: fix up qt packages for init at 0.5.4 rmg: remove seperate 'wrapQtAppsHook' from imports for init at 0.5.4 rmg: add myself to 'maintainer-list.nix' for init at 0.5.4
|
@ofborg build rmg |
|
@bachp |
Description of changes
Adds Rosalie's Mupen GUI to nixpkgs
NOTE: This project ships it's own mupen64plus-core instead of using the one that's already been packaged. It also comes
with plugins (such as GLideN64) that are compiled during the build phase.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)I've tested the program by changing plugins and playing through small chunks of some games.
Add a 👍 reaction to pull requests you find important.