gjs: 1.78.1 -> 1.78.3

[trofi]

Changes:

• https://gitlab.gnome.org/GNOME/gjs/-/blob/1.78.2/NEWS
• https://gitlab.gnome.org/GNOME/gjs/-/blob/1.78.3/NEWS

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[amaxine]

@ofborg build gjs gjs.tests

[amaxine]

Tests don't work, but it seems like tests also currently don't work on master. Would be nice to fix that.

[trofi]

Yeah, looks like Xorg fails to start for DRI initialization problems:

vm-test-run-gjs> machine # #9  0x00007f9843d6a884 u_pipe_screen_get_param_defaults (kms_swrast_dri.so + 0xc80884)
vm-test-run-gjs> machine # #10 0x00007f984319eb50 dri2_init_screen_extensions (kms_swrast_dri.so + 0xb4b50)
vm-test-run-gjs> machine # #11 0x00007f984319ef70 dri_swrast_kms_init_screen (kms_swrast_dri.so + 0xb4f70)

[trofi]

Bisected gjs test suite regression down to mesa update in be9351c mesa: 23.3.1 -> 23.3.2.

Reverting be9351c mesa: 23.3.1 -> 23.3.2 restores the test.

UPDATE: added the comment as #277570 (comment)

[trofi]

Vladimir suggested testing fresher staging that contains mesa-23.3.3 and that makes that error to go away.

One more fix is needed for gjs to pass. It's a pam regression. Proposed fix as #281182

[trofi]

All the test blockers should be fixed now. Rebased against current staging.

[amaxine]

https://gitlab.gnome.org/GNOME/gjs/-/blob/1.78.3/NEWS fixes a major regression, assuming it doesn't break anything let's update before merging.

[trofi]

Updated to 1.78.3

[amaxine]

Thanks. gjs builds fine, I'll merge after my local build of tests finishes (been going for ~5 hours so far).

[amaxine]

Just finished, all good!

[github-actions]

Backport failed for staging-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin staging-23.11
git worktree add -d .worktree/backport-279871-to-staging-23.11 origin/staging-23.11
cd .worktree/backport-279871-to-staging-23.11
git switch --create backport-279871-to-staging-23.11
git cherry-pick -x 234a90427a2707de5b73b4a28be51a2f8d3e5740