Merged
Conversation
ofborg
bot
added
11.by: package-maintainer
thiagokokada
force-pushed
the
bump-mcomix
branch
from
4ad1742 to
42a3cb8
Compare
AndersonTorres
approved these changes
Jan 8, 2024
otavio
reviewed
Jan 8, 2024
| src = fetchurl { | ||
| url = "mirror://sourceforge/mcomix/${pname}-${version}.tar.gz"; | ||
| hash = "sha256-fmnlPhNCN6YR3lW2YCMEAbEiWVigcfFDq1tDQ1eTNkA="; | ||
| url = "mirror://sourceforge/mcomix/mcomix-${version}.tar.gz"; |
Contributor
Author
There was a problem hiding this comment.
This is really something that depends on the person, but in general it is arguably easier to read an URL that does not parametrize unnecessary things like pname.
Contributor
|
Result of 2 packages built:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.