python311Packages.recursive-pth-loader: rename from recursivePthLoader#279384
Merged
Stunkymonkey merged 1 commit intoNixOS:masterfrom Jan 28, 2024
Merged
Conversation
github-actions
bot
added
6.topic: python
Stunkymonkey
force-pushed
the
recursive-pth-loader-normalize
branch
from
6703300 to
e6ed329
Compare
Contributor
Author
|
Result of 1 package blacklisted:
2 packages built:
|
ofborg
bot
added
8.has: clean-up
jfly
approved these changes
Jan 14, 2024
Contributor
jfly
left a comment
jfly
left a comment
There was a problem hiding this comment.
One comment about something I don't know anything about. Otherwise, LGTM!
Contributor
There was a problem hiding this comment.
For the record, I don't understand the consequences of moving this.
Contributor
Author
There was a problem hiding this comment.
I don't understand why it was there in the first place...
Contributor
There was a problem hiding this comment.
Ok, well, seems reasonable to try to move it and see what happens. Either it's safe and good, or we learn something =)
Member
|
Is |
AndersonTorres
approved these changes
Jan 25, 2024
Contributor
Author
|
rebasing due to #277321 |
Stunkymonkey
force-pushed
the
recursive-pth-loader-normalize
branch
from
e6ed329 to
d35003e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
part of #245383
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.