Skip to content

gnome.gnome-user-share: Fix eval with allowAliases = false#278744

Merged
infinisil merged 2 commits intoNixOS:masterfrom
jtojnar:gnome-user-share-fix
Jan 4, 2024
Merged

gnome.gnome-user-share: Fix eval with allowAliases = false#278744
infinisil merged 2 commits intoNixOS:masterfrom
jtojnar:gnome-user-share-fix

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Jan 4, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jtojnar jtojnar force-pushed the gnome-user-share-fix branch from eab2590 to 26ea4a7 Compare January 4, 2024 18:33
@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jan 4, 2024
@jtojnar jtojnar mentioned this pull request Jan 4, 2024
Merged
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jan 4, 2024
@ofborg ofborg bot requested review from amaxine, bobby285271, dasj19 and hedning January 4, 2024 19:04
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 4, 2024
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 4, 2024
@infinisil
Copy link
Member

infinisil commented Jan 4, 2024

Failing since #276112 but not detected due to #271123 (comment)

@infinisil infinisil merged commit fec6c9b into NixOS:master Jan 4, 2024
@infinisil infinisil mentioned this pull request Jan 4, 2024
Merged
@jtojnar jtojnar deleted the gnome-user-share-fix branch January 5, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjornfor bjornfor bjornfor approved these changes

@amaxine amaxine Awaiting requested review from amaxine

@dasj19 dasj19 Awaiting requested review from dasj19

@hedning hedning Awaiting requested review from hedning

@bobby285271 bobby285271 Awaiting requested review from bobby285271

Assignees

No one assigned

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jtojnar @infinisil @bjornfor @delroth