lomiri.lomiri-system-settings{,-unwrapped,-security-privacy}: init at 1.0.2#278374
Merged
pbsds merged 4 commits intoNixOS:masterfrom Feb 26, 2024
Merged
lomiri.lomiri-system-settings{,-unwrapped,-security-privacy}: init at 1.0.2#278374pbsds merged 4 commits intoNixOS:masterfrom
pbsds merged 4 commits intoNixOS:masterfrom
Conversation
a62e656 to
73390fc
Compare
73390fc to
ba16847
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ba16847 to
55aab20
Compare
55aab20 to
2c03c50
Compare
e393284 to
4d15821
Compare
4d15821 to
860d8ef
Compare
d0f12b6 to
4308ac4
Compare
pbsds
reviewed
Feb 25, 2024
Member
pbsds
left a comment
There was a problem hiding this comment.
whoops, didn't submit the review. I must've been working on it when my laptop died on the train.
Result of nixpkgs-review pr 278374 run on x86_64-linux 1
4 packages built:
- lomiri.lomiri-system-settings
- lomiri.lomiri-system-settings-security-privacy
- lomiri.lomiri-system-settings-unwrapped
- lomiri.lomiri-system-settings-unwrapped.dev
nixos test passes locally 👍
pkgs/desktops/lomiri/applications/lomiri-system-settings/wrapper.nix
Outdated
Show resolved
Hide resolved
...miri/applications/lomiri-system-settings/plugins/lomiri-system-settings-security-privacy.nix
Outdated
Show resolved
Hide resolved
4308ac4 to
50d2894
Compare
wineee
requested changes
Feb 25, 2024
pkgs/desktops/lomiri/applications/lomiri-system-settings/wrapper.nix
Outdated
Show resolved
Hide resolved
wineee
reviewed
Feb 25, 2024
pkgs/desktops/lomiri/applications/lomiri-system-settings/default.nix
Outdated
Show resolved
Hide resolved
50d2894 to
bf4d92b
Compare
wineee
requested changes
Feb 25, 2024
pkgs/desktops/lomiri/applications/lomiri-system-settings/default.nix
Outdated
Show resolved
Hide resolved
946a583 to
f277fb9
Compare
wineee
requested changes
Feb 26, 2024
pkgs/desktops/lomiri/applications/lomiri-system-settings/default.nix
Outdated
Show resolved
Hide resolved
f277fb9 to
66129d5
Compare
wineee
approved these changes
Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Working towards #99090.
Lomiri System Settings is the main settings app for Lomiri. It's also one of the more integral parts of the
lomirishell & experience:If my overview of dependencies isn't super off, then this should be one of the last big dependencies (if not the last big dependency) needed for building the
lomirishell.I've submitted everything that I think is good to have for everyone upstream, but some things remain on our end:
lomiri-keyboardwithmaliit-keyboard. I have so far been unable to get either of them working, butmaliit-keyboardsaves us a dependency. Debian is also patching this tomaliit-keyboard, andlomiri-keyboardmight get replaced bymaliit-keyboard, so this seems fine to me.To ensure that everything works, I have packaged one of the external plugins (security-privacy) and added a VM test that:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.