Conversation
e74b1b4 to
e41c63d
Compare
|
@SomeoneSerge thank you for the detailed feedback, I think I integrated everything you pointed out. |
a8eea68 to
02c283f
Compare
|
Result of |
|
I've switched a system with cudaSupport to this PR and tested ollama works |
02c283f to
47fc482
Compare
|
@SomeoneSerge gave it another round of changes. Let me know. |
|
if all the settings are exclusive, one solution could be to replace the booleans with a string |
I'm not sure what exactly is the situation upstream wrt the interaction of these options, so in a way the bool flags might be justified. They let the end-user try the cursed things out, and we do communicate the supported variants using |
SomeoneSerge
left a comment
There was a problem hiding this comment.
We should wait for Ofborg, but otherwise I think the PR is ready (within the scope suggested by the title)
Thanks @happysalada!
|
Result of |
|
I've tested ollama on a system with cudaSupport with this PR. |
Description of changes
this fixes cuda support.
an attempt at addressing #272569
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.