nixos/gnupg: drop references to gtk2; pinentry-*: build dependent variant with an override instead of choosing the output by SuperSandro2000 · Pull Request #277221 · NixOS/nixpkgs

SuperSandro2000 · 2023-12-28T01:50:33Z

Description of changes

This PR basically cleans up all #270266

see #270266 (comment)
Closes #276143
Closes #133156

Things done

Add a 👍 reaction to pull requests you find important.

con-f-use · 2023-12-28T13:25:30Z

Just wanted to mention again, that all the other pinentry flavors don't handle both tty and graphical prompts as well as gtk2. It's either or with them, so I don't think it should be dropped as a pinentry flavor.

SuperSandro2000 · 2023-12-29T03:14:48Z

all the other pinentry flavors don't handle both tty and graphical prompts as well as gtk2.

I am not sure how gtk2 is realted to tty/curses.

It's either or with them, so I don't think it should be dropped as a pinentry flavor.

It is only dropped as a default entry. You can still configure it to use it.

pkgs/tools/security/pinentry/default.nix

ElvishJerricco · 2024-01-03T06:33:44Z

@SuperSandro2000

I am not sure how gtk2 is realted to tty/curses.

The gtk2 pinentry flavor is the only one that will correctly prompt in the terminal if necessary, or graphically if available. e.g. If I SSH into my machine, I can still use gpg with the gtk2 pinentry flavor, because it will put the prompt in the terminal. Meanwhile, it will still give a graphical prompt if I'm using it from the desktop environment. Other graphical pinentry flavors will always put up the graphical prompt on the desktop, even if you're logged in remotely with SSH.

nixos/modules/programs/gnupg.nix

The GTK2 variant has been removed [1]. I may revise this in the future if [2] is merged (I'd like to try `pinentry-rofi` [3]). [1]: NixOS/nixpkgs#270266 [2]: NixOS/nixpkgs#277221 [3]: https://github.com/plattfot/pinentry-rofi

pkgs/top-level/all-packages.nix

jtojnar · 2024-01-03T23:40:27Z

pkgs/top-level/all-packages.nix

I vaguely recall that curses was supposed to be a fallback, if gui could not be started. But now the only reference I found is #71095 (comment), which is not very informative.

nixos/modules/programs/gnupg.nix

…ing the output We don't want to depend on the *enabled* flavors of pinentry but on all *possible* ones.

… definitely enabled

This avoids evaluating all the desktop environments at this place.

SuperSandro2000 · 2024-01-14T19:58:21Z

I cannot test all the changes myself - I think they they are correct but I would appreciate it, if other people could help to verify that.

fpletz

Changes LGTM. Since I'm also using pinentry both graphically and with curses I'm gonna test and merge later today if nobody beats me to it.

fpletz

Do not merge for now since only setting one enabledFlavor probably does not provide a proper fallback.

SuperSandro2000 · 2024-01-15T10:33:04Z

Do not merge for now since only setting one enabledFlavor probably does not provide a proper fallback.

I vaguely recall that curses was supposed to be a fallback, if gui could not be started. But now the only reference I found is #71095 (comment), which is not very informative.

Based on this I am not sure that is even working.

fpletz · 2024-01-15T13:29:02Z

Based on this I am not sure that is even working.

I'm using this functionality daily and others have also noted they are using this in other PRs regarding the breakage of pinentry-gtk2.

rnhmjoj

Looks good to me. I like that DEs set the flavour they need, instead of having gnupg handling it for each and every one.

fpletz · 2024-01-15T16:35:21Z

Some of the useful changes here have been carried over to #133542. Since this PR effectively breaks pinentry's fallback feature, we'll continue in the other PR.

SuperSandro2000 · 2024-01-15T16:43:52Z

I'm using this functionality daily and others have also noted they are using this in other PRs regarding the breakage of pinentry-gtk2.

yeah, gtk2 but we don't really know that for the other flavors and I kinda remember that jan some time said, that this might not work.

github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 28, 2023

SuperSandro2000 mentioned this pull request Dec 28, 2023

Revert "pinentry: drop gtk2" #276143

Merged

13 tasks

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 28, 2023

SuperSandro2000 mentioned this pull request Dec 29, 2023

Remove GTK2 from a typical plasma installation #270266

Merged

13 tasks

SuperSandro2000 changed the title ~~nixos/gnupg: drop references to gtk2~~ nixos/gnupg: drop references to gtk2; pinentry-*: build dependent variant with an override instead of choosing the output Dec 29, 2023

SuperSandro2000 requested review from K900, lheckemann and rnhmjoj December 29, 2023 03:30

SuperSandro2000 mentioned this pull request Dec 29, 2023

pinentry: excessive derivation closure size #133156

Closed

roberth reviewed Dec 30, 2023

View reviewed changes

pkgs/tools/security/pinentry/default.nix Outdated Show resolved Hide resolved

lobre reviewed Jan 3, 2024

View reviewed changes

nixos/modules/programs/gnupg.nix Outdated Show resolved Hide resolved

ambroisie reviewed Jan 3, 2024

View reviewed changes

nixos/modules/programs/gnupg.nix Outdated Show resolved Hide resolved

jtojnar reviewed Jan 3, 2024

View reviewed changes

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved

SuperSandro2000 force-pushed the pinentry-gtk2-followup branch from 1a80033 to 927f8ae Compare January 3, 2024 23:37

jtojnar reviewed Jan 3, 2024

View reviewed changes

SuperSandro2000 force-pushed the pinentry-gtk2-followup branch from 927f8ae to 3cdf170 Compare January 4, 2024 00:04

ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Jan 4, 2024

ofborg bot requested review from fpletz and ttuegel January 4, 2024 02:54

ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jan 4, 2024

SuperSandro2000 requested review from ambroisie and lobre January 8, 2024 23:10

SuperSandro2000 requested review from jtojnar and roberth January 8, 2024 23:10

ambroisie approved these changes Jan 9, 2024

View reviewed changes

delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 9, 2024

roberth reviewed Jan 9, 2024

View reviewed changes

nixos/modules/programs/gnupg.nix Outdated Show resolved Hide resolved

This was referenced Jan 14, 2024

pinentry-bemenu/pinentry-rofi/pinentry_mac: add 'meta.mainProgram' #280982

Merged

rbw/gpg-agent: improve pinentry options nix-community/home-manager#4895

Merged

SuperSandro2000 force-pushed the pinentry-gtk2-followup branch from 3cdf170 to 78ef9f0 Compare January 14, 2024 19:55

github-actions bot added 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: xfce The Xfce Desktop Environment 6.topic: LXQt The Lightweight Qt Desktop Environment labels Jan 14, 2024

SuperSandro2000 added 4 commits January 14, 2024 20:56

nixos/gnupg: drop references to gtk2, fix ncurses typo

945f9fe

pinentry-*: build dependent variant with an override instead of choos…

a880b50

…ing the output We don't want to depend on the *enabled* flavors of pinentry but on all *possible* ones.

nixos/gnupg: choose the pinentry variant that has the selected flavor…

1de7c1d

… definitely enabled

programs/gnupg: move agent.pinentryFlavor to the desktops

daa53d2

This avoids evaluating all the desktop environments at this place.

SuperSandro2000 force-pushed the pinentry-gtk2-followup branch from 78ef9f0 to daa53d2 Compare January 14, 2024 19:57

fpletz approved these changes Jan 15, 2024

View reviewed changes

fpletz requested changes Jan 15, 2024

View reviewed changes

fpletz mentioned this pull request Jan 15, 2024

pinentry: remove multiple outputs #133542

Merged

11 tasks

rnhmjoj approved these changes Jan 15, 2024

View reviewed changes

fpletz closed this Jan 15, 2024

SuperSandro2000 deleted the pinentry-gtk2-followup branch January 15, 2024 16:43

Uh oh!

Conversation

SuperSandro2000 commented Dec 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Things done

Uh oh!

con-f-use commented Dec 28, 2023

Uh oh!

SuperSandro2000 commented Dec 29, 2023

Uh oh!

Uh oh!

ElvishJerricco commented Jan 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jtojnar Jan 3, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SuperSandro2000 commented Jan 14, 2024

Uh oh!

fpletz left a comment

Choose a reason for hiding this comment

Uh oh!

fpletz left a comment

Choose a reason for hiding this comment

Uh oh!

SuperSandro2000 commented Jan 15, 2024

Uh oh!

fpletz commented Jan 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rnhmjoj left a comment

Choose a reason for hiding this comment

Uh oh!

fpletz commented Jan 15, 2024

Uh oh!

SuperSandro2000 commented Jan 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

SuperSandro2000 commented Dec 28, 2023 •

edited

Loading

fpletz commented Jan 15, 2024 •

edited

Loading