Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamviewer: 15.38.3 -> 15.49.2 #276948

Merged
merged 2 commits into from
Mar 23, 2024
Merged

teamviewer: 15.38.3 -> 15.49.2 #276948

merged 2 commits into from
Mar 23, 2024

Conversation

ifurther
Copy link
Contributor

@ifurther ifurther commented Dec 26, 2023 •
edited
Loading

Description of changes

Update the version. Fix CVE-2023-38545

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 26, 2023
@gador
Copy link
Member

gador commented Jan 13, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 276948 run on x86_64-linux 1

2 packages failed to build and are new build failures:

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

teamviewer:

warning: EvalError
Cannot evaluate attribute ‘teamviewer’ in ‘/nix/store/n0vz551ys4f93jcyyb7660fqiazcbc5c-nixpkgs’.

@gador
Copy link
Member

gador commented Jan 13, 2024

PR fails for me with:

teamviewer> auto-patchelf: 11 dependencies could not be satisfied
teamviewer> error: auto-patchelf could not satisfy dependency libQt5QuickTemplates2.so.5 wanted by /nix/store/69azqxbdnckw1hkwn2wcf9da7rbhpi8i-teamviewer-15.49.2/share/teamviewer/tv_bin/RTlib/qt/qml/QtQuick/Controls.2/libqtquickcontrols2plugin.so
teamviewer> error: auto-patchelf could not satisfy dependency libQt5QuickControls2.so.5 wanted by /nix/store/69azqxbdnckw1hkwn2wcf9da7rbhpi8i-teamviewer-15.49.2/share/teamviewer/tv_bin/RTlib/qt/qml/QtQuick/Controls.2/libqtquickcontrols2plugin.so
teamviewer> error: auto-patchelf could not satisfy dependency libQt5QuickTemplates2.so.5 wanted by /nix/store/69azqxbdnckw1hkwn2wcf9da7rbhpi8i-teamviewer-15.49.2/share/teamviewer/tv_bin/RTlib/qt/qml/QtQuick/Controls.2/Imagine/libqtquickcontrols2imaginestyleplugin.so
teamviewer> error: auto-patchelf could not satisfy dependency libQt5QuickControls2.so.5 wanted by /nix/store/69azqxbdnckw1hkwn2wcf9da7rbhpi8i-teamviewer-15.49.2/share/teamviewer/tv_bin/RTlib/qt/qml/QtQuick/Controls.2/Imagine/libqtquickcontrols2imaginestyleplugin.so
teamviewer> error: auto-patchelf could not satisfy dependency libQt5QuickTemplates2.so.5 wanted by /nix/store/69azqxbdnckw1hkwn2wcf9da7rbhpi8i-teamviewer-15.49.2/share/teamviewer/tv_bin/RTlib/qt/qml/QtQuick/Controls.2/Fusion/libqtquickcontrols2fusionstyleplugin.so
teamviewer> error: auto-patchelf could not satisfy dependency libQt5QuickControls2.so.5 wanted by /nix/store/69azqxbdnckw1hkwn2wcf9da7rbhpi8i-teamviewer-15.49.2/share/teamviewer/tv_bin/RTlib/qt/qml/QtQuick/Controls.2/Fusion/libqtquickcontrols2fusionstyleplugin.so
teamviewer> error: auto-patchelf could not satisfy dependency libQt5QuickTemplates2.so.5 wanted by /nix/store/69azqxbdnckw1hkwn2wcf9da7rbhpi8i-teamviewer-15.49.2/share/teamviewer/tv_bin/RTlib/qt/qml/QtQuick/Controls.2/Universal/libqtquickcontrols2universalstyleplugin.so
teamviewer> error: auto-patchelf could not satisfy dependency libQt5QuickControls2.so.5 wanted by /nix/store/69azqxbdnckw1hkwn2wcf9da7rbhpi8i-teamviewer-15.49.2/share/teamviewer/tv_bin/RTlib/qt/qml/QtQuick/Controls.2/Universal/libqtquickcontrols2universalstyleplugin.so
teamviewer> error: auto-patchelf could not satisfy dependency libQt5QuickTemplates2.so.5 wanted by /nix/store/69azqxbdnckw1hkwn2wcf9da7rbhpi8i-teamviewer-15.49.2/share/teamviewer/tv_bin/RTlib/qt/qml/QtQuick/Controls.2/Material/libqqc2materialstyleplugin.so
teamviewer> error: auto-patchelf could not satisfy dependency libQt5QuickControls2.so.5 wanted by /nix/store/69azqxbdnckw1hkwn2wcf9da7rbhpi8i-teamviewer-15.49.2/share/teamviewer/tv_bin/RTlib/qt/qml/QtQuick/Controls.2/Material/libqqc2materialstyleplugin.so
teamviewer> error: auto-patchelf could not satisfy dependency libQt5QuickTemplates2.so.5 wanted by /nix/store/69azqxbdnckw1hkwn2wcf9da7rbhpi8i-teamviewer-15.49.2/share/teamviewer/tv_bin/RTlib/qt/qml/QtQuick/Templates.2/libqtquicktemplates2plugin.so
teamviewer> auto-patchelf failed to find all the required dependencies.
teamviewer> Add the missing dependencies to --libs or use `--ignore-missing="foo.so.1 bar.so etc.so"`.

@ifurther
Copy link
Contributor Author

@gador I add the require package qtquickcontrols2

@gador
Copy link
Member

gador commented Jan 29, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 276948 run on x86_64-linux 1

2 packages built:
  • teamviewer
  • teamviewer.dev

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

teamviewer:

warning: EvalError
Cannot evaluate attribute ‘teamviewer’ in ‘/nix/store/ddr6nxpk51m6vgc9n941rv2p27yq44sc-nixpkgs’.

gador
gador approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@gador gador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Builds and runs in a VM

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Mar 8, 2024
@ifurther ifurther added backport release-23.11 1.severity: security Issues which raise a security issue, or PRs that fix one labels Mar 17, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3673

@SuperSandro2000 SuperSandro2000 merged commit f657061 into NixOS:master Mar 23, 2024
29 checks passed
@github-actions github-actions bot mentioned this pull request Mar 23, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

pull bot pushed a commit to b-/nixpkgs that referenced this pull request Mar 27, 2024
@ifurther @pull
teamviewer: 15.38.3 -> 15.49.2 (NixOS#276948)
719899d 
* teamviewer: 15.38.3 -> 15.49.2

* teamviewer: add qtquickcontrols2
@tobias-kuendig tobias-kuendig mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gador gador gador approved these changes

@jraygauthier jraygauthier Awaiting requested review from jraygauthier

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ifurther @gador @nixos-discourse @SuperSandro2000 @wegank