Skip to content

nix: point nix edit and ofborg at the original version attribute#276892

Merged
lovesegfault merged 1 commit intoNixOS:masterfrom
trofi:nix-set-pos-attribute
Jan 15, 2024
Merged

nix: point nix edit and ofborg at the original version attribute#276892
lovesegfault merged 1 commit intoNixOS:masterfrom
trofi:nix-set-pos-attribute

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Dec 26, 2023

This way nix edit will just at the location close to the attribute definition and not the common code.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This way `nix edit` will just at the location close to the attribute
definition and not the common code.
@trofi trofi changed the title nix: point nix edit and ofborf at the original version attribute nix: point nix edit and ofborg at the original version attribute Dec 26, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 26, 2023
@trofi trofi mentioned this pull request Jan 13, 2024
13 tasks
@lovesegfault lovesegfault merged commit fae1524 into NixOS:master Jan 15, 2024
@trofi trofi deleted the nix-set-pos-attribute branch January 15, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants