Skip to content

genericUpdater: Add support for commit protocol#276828

Merged
jtojnar merged 1 commit intoNixOS:masterfrom
jtojnar:generic-updater-commits
Jan 14, 2024
Merged

genericUpdater: Add support for commit protocol#276828
jtojnar merged 1 commit intoNixOS:masterfrom
jtojnar:generic-updater-commits

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Dec 26, 2023

Description of changes

This will allow it to work with _experimental-update-script-combinators.sequence.

https://nixos.org/manual/nixpkgs/stable/#var-passthru-updateScript-commit

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This will allow it to work with _experimental-update-script-combinators.sequence.
@jtojnar jtojnar mentioned this pull request Dec 26, 2023
13 tasks
@jtojnar jtojnar requested a review from romildo December 26, 2023 01:59
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 26, 2023
Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 26, 2023
@jtojnar jtojnar merged commit d81eeb4 into NixOS:master Jan 14, 2024
@jtojnar jtojnar deleted the generic-updater-commits branch January 14, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants