cudaPackages: eliminate exceptions#276800
Merged
SomeoneSerge merged 2 commits intoNixOS:masterfrom Dec 26, 2023
Merged
Conversation
SomeoneSerge
commented
Dec 25, 2023
Contributor
Author
There was a problem hiding this comment.
We can make this warn "Unknown architecture: ${cap}" "sm_${...}" later. Right now I just want cleaner eval
SomeoneSerge
force-pushed
the
fix/cuda-no-throw
branch
2 times, most recently
from
9fb3b38 to
95a3b0d
Compare
as they break common nixpkgs tools like lib.meta, cf. NixOS#276795
SomeoneSerge
force-pushed
the
fix/cuda-no-throw
branch
from
95a3b0d to
cf21437
Compare
github-actions
bot
added
the
6.topic: python
ofborg
bot
requested review from
ConnorBaker,
abbradar,
aidalgol,
mdaiter and
samuela
ofborg
bot
added
10.rebuild-darwin: 11-100
aidalgol
approved these changes
Dec 26, 2023
delroth
added
12.approvals: 1
Contributor
Author
|
Some of the outPaths have changed because the "unsupported" packages now have more The solutions here are highly sub-optimal. There are upcoming refactors to the evalModules bit (incl. in Connor's cross-compilation PR) which might address this properly. It took some effort to satisfy Ofborg here without more global changes. Ofborg happy, and thanks to @aidalgol for the review. Merging this so we can start using |
SomeoneSerge
commented
Dec 26, 2023
| }; | ||
|
|
||
| meta = with lib; { | ||
| badPlatforms = lib.optionals cudaSupport lib.platforms.darwin; |
Contributor
Author
There was a problem hiding this comment.
This was required because of the "missing attribute cudnn_8_6"
This was referenced Jan 8, 2024
Member
|
This indirectly broke the channel build, fix in #279684 |
infinisil
added a commit
that referenced
this pull request
Jan 8, 2024
This very weirdly broke the channel evaluation: https://hydra.nixos.org/build/245871962/nixlog/1 It appears that this attribute is only evaluated by Hydra, _not_ by ofborg. So this wouldn't have been detected by CI anyways in the PR that introduced the problem: #276800. However, due to #271123 (comment), the channel only broke once that was fixed with #278777 Whether the fix is good, I don't know, but the failing-on-darwin attribute doesn't exist anymore with this commit, making the tarball build succeed again: nix-build pkgs/top-level/release.nix -A tarball
This was referenced May 11, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as they break common nixpkgs tools like lib.meta,
cf. #276795
@NixOS/cuda-maintainers
Description of changes
Before:
After:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.