fwknop: pull fix for autoconf-2.72 build pending upstream inclusion#276757
Merged
primeos merged 1 commit intoNixOS:masterfrom Dec 28, 2023
Merged
fwknop: pull fix for autoconf-2.72 build pending upstream inclusion#276757primeos merged 1 commit intoNixOS:masterfrom
autoconf-2.72 build pending upstream inclusion#276757primeos merged 1 commit intoNixOS:masterfrom
Conversation
Without the change the build against `autoconf-2.72` fails as:
fwknop> ./configure: line 18863: syntax error near unexpected token `;;'
fwknop> ./configure: line 18863: ` ;;'
Contributor
Author
|
Result of 1 package built:
|
ofborg
bot
added
10.rebuild-darwin: 0
primeos
approved these changes
Dec 28, 2023
Member
primeos
left a comment
primeos
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing the package and sending the patch upstream! :)
Unfortunately fwknop is more or less abandoned/unmaintained, IIRC... :(
I'm not using fwknop anymore so I should also remove myself as the maintainer.
We could additionally consider deprecating the package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change the build against
autoconf-2.72fails as:Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.