libsidplayfp: pull fix for autoconf-2.72 pending upstream inclusion#276687
Merged
marsam merged 1 commit intoNixOS:masterfrom Dec 28, 2023
Merged
libsidplayfp: pull fix for autoconf-2.72 pending upstream inclusion#276687marsam merged 1 commit intoNixOS:masterfrom
autoconf-2.72 pending upstream inclusion#276687marsam merged 1 commit intoNixOS:masterfrom
Conversation
Without the change `libsidplayfp` fails the build on `autoconf-2.72` as:
./configure: line 19606: syntax error near unexpected token `;;'
./configure: line 19606: ` ;;'
Contributor
Author
|
Result of 7 packages built:
|
ofborg
bot
added
10.rebuild-darwin: 1-10
OPNA2608
approved these changes
Dec 25, 2023
Contributor
OPNA2608
left a comment
OPNA2608
left a comment
There was a problem hiding this comment.
Can't run nixpkgs-review on current hardware, but checked building {,lib}sidplayfp on aarch64-linux.
- Commit could potentially be changed to the now-merged libsidplayfp/libsidplayfp@2b1b41b, but doesn't really matter since they're the same.
- The patch's
nameis potentially confusing, I would at least add a-compat.patchto it. More of a nit though, I potentially just care too much about that when I fetch patches.
Looks good-ish to me.
delroth
added
the
12.approvals: 1
OPNA2608
added
the
12.approved-by: package-maintainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change
libsidplayfpfails the build onautoconf-2.72as:Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.