_0verkill: pin to autoconf-2.69#276459
Merged
marsam merged 1 commit intoNixOS:masterfrom Dec 28, 2023
Merged
Conversation
`autoconf-2.72` tweaked `AC_CHECK_LIB` macro a bit and exposed missing
quoting in `configure.in` of `0verkill` as:
0verkill-unstable> ./configure: line 4182: syntax error near unexpected token `newline'
0verkill-unstable> ./configure: line 4182: `yes:'
`configure.in` requires a bit of patching. Let's pin it to older `2.69`
to allow `autoconf` upgrade to 2.72.
ofborg
bot
added
10.rebuild-darwin: 1-10
AndersonTorres
approved these changes
Dec 24, 2023
delroth
added
the
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
autoconf-2.72tweakedAC_CHECK_LIBmacro a bit and exposed missing quoting inconfigure.inof0verkillas:configure.inrequires a bit of patching. Let's pin it to older2.69to allowautoconfupgrade to 2.72.Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.