Skip to content

libssh2: add some key reverse-dependencies to passthru.tests#276144

Merged
risicle merged 1 commit intoNixOS:masterfrom
risicle:ris-libssh2-passthru-tests
Aug 4, 2024
Merged

libssh2: add some key reverse-dependencies to passthru.tests#276144
risicle merged 1 commit intoNixOS:masterfrom
risicle:ris-libssh2-passthru-tests

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Dec 22, 2023

Description of changes

This is useful for packages which have too many reverse-dependencies to sensibly do a nixpkgs-review for.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 22, 2023
@risicle risicle force-pushed the ris-libssh2-passthru-tests branch from 966181e to d7e45d5 Compare December 23, 2023 00:31
@risicle risicle force-pushed the ris-libssh2-passthru-tests branch from d7e45d5 to 69537e6 Compare December 23, 2023 00:41
@risicle risicle added the 8.has: tests This PR has tests label Dec 25, 2023
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 3, 2024
@Aleksanaa Aleksanaa added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 3, 2024
@risicle risicle merged commit 05a5c05 into NixOS:master Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: tests This PR has tests 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants