Skip to content

Lazier license checks#276120

Open
infinisil wants to merge 4 commits intoNixOS:masterfrom
tweag:lazier-license-checks
Open

Lazier license checks#276120
infinisil wants to merge 4 commits intoNixOS:masterfrom
tweag:lazier-license-checks

Conversation

@infinisil
Copy link
Member

Description of changes

This makes certain top-level attributes evaluate by deferring license checks into drvPath/outPath using lib.extendDerivation:

  • androidsdk_9_0
  • gams
  • neoload
  • sc2-headless

Things done

  • Checked that each attribute evaluates with nix-instantiate --eval -A <attr>, but fails with nix-instantiate -A <attr> (since this evaluates the outPath)

Add a 👍 reaction to pull requests you find important.

Makes the top-level attribute itself evaluate, allowing querying of metadata and
co.
Makes the top-level attribute itself evaluate, allowing querying of metadata and
co.
Makes the top-level attribute itself evaluate, allowing querying of metadata and
co.
Makes the top-level attribute itself evaluate, allowing querying of metadata and
co.
@infinisil infinisil force-pushed the lazier-license-checks branch from dd0b474 to 4dafad3 Compare December 22, 2023 19:50
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 22, 2023
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@Pandapip1
Copy link
Member

There really ought to be a consistent pattern for how to require licenses.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 6, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants