Skip to content

ncmpc: propable fix for x86_64-darwin build error#2761

Closed
christianlask wants to merge 1 commit intoNixOS:masterfrom
christianlask:ncmpc-darwin
Closed

ncmpc: propable fix for x86_64-darwin build error#2761
christianlask wants to merge 1 commit intoNixOS:masterfrom
christianlask:ncmpc-darwin

Conversation

@christianlask
Copy link
Copy Markdown

This patch should fix http://hydra.nixos.org/build/11243446.

@vcunat vcunat closed this in 25ea04f May 26, 2014
@vcunat
Copy link
Copy Markdown
Member

vcunat commented May 26, 2014

OK, let's try it. Pushed with a syntactic change. Some packages seemed also to need -lintl on darwin, we'll see.

@christianlask
Copy link
Copy Markdown
Author

Thanks!

Since I am not that familiar yet with nix and all, would you mind explaining your syntactic change?

@vcunat
Copy link
Copy Markdown
Member

vcunat commented May 26, 2014

libintlOrEmpty is a list, so to get a flat list you can't just add it inside, but you need to append it.

@vcunat
Copy link
Copy Markdown
Member

vcunat commented May 26, 2014

Maybe nested lists would work, but it certainly seems cleaner this way.

@christianlask
Copy link
Copy Markdown
Author

Ah, thanks. That explains a lot :)

@christianlask
Copy link
Copy Markdown
Author

Well, apparently, this doesn't fix it. :(

@vcunat
Copy link
Copy Markdown
Member

vcunat commented May 27, 2014

Tried adding -lintl. Unfortunately, I'm unable to test darwin builds myself.

@wmertens
Copy link
Copy Markdown
Contributor

It builds : http://hydra.nixos.org/build/11276289

@christianlask
Copy link
Copy Markdown
Author

Indeed, it does. Thanks :) (I've received mail from Hydra, but was unable to access my computer until now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants