cudaPackages.cuda_nvcc: patch nvcc.profile#275922
Merged
SomeoneSerge merged 3 commits intoNixOS:masterfrom Dec 23, 2023
Merged
Conversation
ofborg
bot
added
11.by: package-maintainer
13 tasks
let nvcc know about cudart and the stub drivers; this way we do not need to search for cudart in the setupCudaHook
This makes @ccroot@ in setupCudaHook redundant when used with the redist cuda packages. We do not touch setupCudaHook yet, because we still have to address the deprecated cudaPackages.cudatoolkit
SomeoneSerge
force-pushed
the
fix/cuda-nvcc-profile
branch
from
9f62248 to
6ac1e13
Compare
delroth
added
12.approvals: 1
Contributor
Author
|
Thanks @samuela! I've a few more commits that move this into a separate hook and apply it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let nvcc know about cudart and the stub drivers; this way we do not need to search for cudart in the setupCudaHook. This shouldn't (I hope) matter for
cudaPackages.cudatoolkitbecause it's got its merged layout@NixOS/cuda-maintainers
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.