dconf: enable cross compilation#275732
Merged
Mindavi merged 1 commit intoNixOS:masterfrom Feb 13, 2024
Merged
Conversation
github-actions
bot
added
the
6.topic: GNOME
uninsane
force-pushed
the
pr-dconf-ed-cross
branch
from
3a405af to
806369a
Compare
uninsane
changed the title
github-actions
bot
removed
the
6.topic: GNOME
ofborg
bot
added
6.topic: cross-compilation
Mindavi
approved these changes
Feb 13, 2024
Contributor
Mindavi
left a comment
Mindavi
left a comment
There was a problem hiding this comment.
Seems like the right approach to me, and good to get rid of the vala and introspection hacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
combined with #267550, this enables
gnome.dconf-editorto cross compile.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.