Skip to content

pdal: enable unit and package tests#275416

Merged
K900 merged 4 commits intomasterfrom
pdal-tests
Jan 8, 2024
Merged

pdal: enable unit and package tests#275416
K900 merged 4 commits intomasterfrom
pdal-tests

Conversation

@imincik
Copy link
Contributor

@imincik imincik commented Dec 19, 2023 •
edited
Loading

Description of changes

  • enable unit tests
  • add package tests
  • add pkg-config test
  • small code cleanup: alphabetical re-ordering of dependencies

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@imincik imincik marked this pull request as draft December 19, 2023 13:42
@imincik imincik changed the title pdal: enable tests pdal: enable unit and package tests Dec 19, 2023
@imincik imincik marked this pull request as ready for review December 19, 2023 14:02
@imincik
Copy link
Contributor Author

imincik commented Dec 19, 2023

@ofborg build pdal

@imincik imincik self-assigned this Dec 19, 2023
@imincik
Copy link
Contributor Author

imincik commented Dec 19, 2023

@ofborg build pdal

@ofborg ofborg bot requested review from das-g, nh2, nialov, sikmir and willcohen December 19, 2023 17:16
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 19, 2023
@imincik
Copy link
Contributor Author

imincik commented Jan 8, 2024

Running PDAL unit tests is broken with PDAL 2.6.2. Fix PDAL/PDAL#4280

@imincik imincik mentioned this pull request Jan 8, 2024
Merged
13 tasks
@K900 K900 merged commit d95f2f3 into master Jan 8, 2024
@imincik
Copy link
Contributor Author

imincik commented Jan 8, 2024 •
edited
Loading

PR discussed in https://matrix.to/#/#staging:nixos.org (https://matrix.to/#/!UNVBThoJtlIiVwiDjU:nixos.org/$ANK0nPZCk3gydbi5cMt1Q5rvuD2hAYZUIFUYbZR-Sd8?via=nixos.org&via=matrix.org&via=nixos.dev) and improved with help of @K900 and @lilyinstarlight . Thanks for help.

@ofborg ofborg bot requested a review from r-burns January 8, 2024 13:42
@nixos-discourse
Copy link

nixos-discourse commented Jan 9, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/week-in-geospatial-team/37035/2

imincik added a commit to imincik/geospatial-nix that referenced this pull request Jan 12, 2024
@imincik
pkgs(pdal): add unit and package tests
d3b828c 
Nixpkgs PR:
NixOS/nixpkgs#275416
@nixos-discourse
Copy link

nixos-discourse commented Jan 16, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/week-in-geospatial-team/37035/3

@wegank wegank deleted the pdal-tests branch January 20, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sikmir sikmir Awaiting requested review from sikmir

@nh2 nh2 Awaiting requested review from nh2

@nialov nialov Awaiting requested review from nialov

@das-g das-g Awaiting requested review from das-g

@willcohen willcohen Awaiting requested review from willcohen

@r-burns r-burns Awaiting requested review from r-burns

Assignees

@imincik imincik

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@imincik @nixos-discourse @K900