Skip to content

Comments

maintainers-list.nix: allow maintainer contact using Discourse#275059

Closed
zeuner wants to merge 1 commit intoNixOS:masterfrom
zeuner:maintainer-discourse
Closed

maintainers-list.nix: allow maintainer contact using Discourse#275059
zeuner wants to merge 1 commit intoNixOS:masterfrom
zeuner:maintainer-discourse

Conversation

@zeuner
Copy link
Contributor

@zeuner zeuner commented Dec 17, 2023

Description of changes

Many maintainers are already registered on Discourse, and it's no less convenient than the other contact possibilities maintainers can currently supply. Additionally, since the Discourse server is ran under control of the NixOS foundation, it provides a platform that can be used for subsequent implementation of maintainer-related automation. Therefore, it seems reasonable to allow maintainers to move more of their maintainership-related communication to Discourse. This is made possible by this PR.

GDPR impact:

This must be taken into account (see https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix#L52) as long as EU citizens are expected to take part in the community. However, the suggested change only adds an optional field, so it won't lead to more processing of personal data than before. Additionally, if maintainers choose to provide a Discourse handle, they may even choose not to provide the other contact details. It remains important to make sure there will be no implicit pressure that would make optional fields mandatory without explicit declaration. But this is a responsibility that is already present with the current schema. Therefore, if the pre-PR situation was GDPR-compliant, so will be the situation afterwards.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 17, 2023
@zeuner zeuner force-pushed the maintainer-discourse branch from 58baf5b to 58c3b72 Compare December 19, 2023 13:47
@zeuner zeuner requested a review from infinisil as a code owner December 19, 2023 13:47
@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Dec 19, 2023
@SuperSandro2000
Copy link
Member

Additionally, since the Discourse server is ran under control of the NixOS foundation

Well, yes and no. It is kindled hosted by Flying Circus but the moderation and so on is done by community members.

@zeuner
Copy link
Contributor Author

zeuner commented Dec 20, 2023

Additionally, since the Discourse server is ran under control of the NixOS foundation

Well, yes and no. It is kindled hosted by Flying Circus but the moderation and so on is done by community members.

Having the hosting part outsourced to a separate entity is not too uncommon. The important question would be whether someone out of the community has access to the database and would thus be able to migrate the Discourse to a different hosting in the event that this would become necessary. If so, I would call that "control" in this context.

The hosting by Flying Circus might imply that an EU standard regarding data protection would apply for that part. This might also be relevant for some maintainers.

@wegank wegank added 2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Jul 4, 2024
@wolfgangwalther
Copy link
Contributor

Closing because it's merge conflicted and the preconditions have changed. If you'd like to add discourse as an other optional contact option besides email and matrix, please rebase and re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants