Skip to content

breeze-icons: generate icon cache#27458

Merged
ttuegel merged 1 commit intoNixOS:masterfrom
ttuegel:bugfix/kde-icon-cache
Jul 18, 2017
Merged

breeze-icons: generate icon cache#27458
ttuegel merged 1 commit intoNixOS:masterfrom
ttuegel:bugfix/kde-icon-cache

Conversation

@ttuegel
Copy link
Member

@ttuegel ttuegel commented Jul 17, 2017

Motivation

Fixes #21345 by generating the icon cache when the theme is installed.

Testing

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Fixes NixOS#21345 by generating the icon cache when the theme is installed.
@ttuegel ttuegel added 0.kind: enhancement Add something new or improve an existing system. 6.topic: qt/kde Object-oriented framework for GUI creation labels Jul 17, 2017
@ttuegel ttuegel self-assigned this Jul 17, 2017
@FRidh
Copy link
Member

FRidh commented Jul 18, 2017

What if one uses other icon sets? (I don't)

@ttuegel
Copy link
Member Author

ttuegel commented Jul 18, 2017

What if one uses other icon sets? (I don't)

The default hicolor icon set is handled by the system environment builder. Other icon sets need to be handled in the same way by their maintainers. I imagine the Gnome icon themes are already treated this way.

@ttuegel ttuegel merged commit 827b0e1 into NixOS:master Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: enhancement Add something new or improve an existing system. 6.topic: qt/kde Object-oriented framework for GUI creation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants