Skip to content

pythonPackages.django_extensions : init at 1.8.1#27378

Merged
FRidh merged 3 commits intoNixOS:masterfrom
wizzup:add-python-django-extensions
Aug 13, 2017
Merged

pythonPackages.django_extensions : init at 1.8.1#27378
FRidh merged 3 commits intoNixOS:masterfrom
wizzup:add-python-django-extensions

Conversation

@wizzup
Copy link
Contributor

@wizzup wizzup commented Jul 14, 2017

Motivation for this change

To add django-extensions to python-modules

Things done
  • Tested using sandboxing : nix.useSandbox on NixOS
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested installation : nix-shell -I nixpkgs=/nix/nixpkgs -p python27Packages.django_extensions python36Packages.django_extensions
  • Tested execution : tested manage.py with shell_plus and graph_models
  • Fits CONTRIBUTING.md.

@wizzup wizzup force-pushed the add-python-django-extensions branch from 3f4fdf0 to dfc66e4 Compare July 14, 2017 09:00
@wizzup wizzup changed the title django-extensions : init at 1.8.1 pythonPackages.django_extensions : init at 1.8.1 Jul 15, 2017
@FRidh FRidh added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 15, 2017
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a comment explaining why you disable tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test was failed at the time I create this PR, due to many dependencies are missing.

I fix this in next commit. Now pass all the tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you maintain this package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I won't. I don't think I have enough knowledge on python packaging.

I use django for my own personal project and found this project useful. Try to install it and think it would save time for other if the package is ready-to-use.

Copy link
Member

@Mic92 Mic92 Jul 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The python packaging part can be handled by core maintainers. Often is more important to have someone, who knows how the library is supposed to work and have ways to use/test newer versions of it.

@wizzup wizzup force-pushed the add-python-django-extensions branch from dfc66e4 to 8dad51b Compare July 18, 2017 09:44
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank a lot. I don't really understand build system (buildInputs, propagatedBuildInputs, nativeBuildInputs, etc). I try reading manual but doesn't fully get them.

Never have any problem with current expression, so I assume I wrote it correctly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For python they have the following semantics:

  • propagatedBuildInputs: all python packages, which should be available for consumers of this package or in other words runtime dependencies
  • buildInputs: dependencies only needed to build the package, for python this is most often test dependencies like mock and pytest.
  • nativeBuildInputs: if this package would be cross-compiled, host-native packages like compilers would be included here, however it is not that common for python packages to require them.

@wizzup wizzup force-pushed the add-python-django-extensions branch from 8dad51b to bf76694 Compare July 22, 2017 09:38
@wizzup wizzup force-pushed the add-python-django-extensions branch from bf76694 to d903b4f Compare July 22, 2017 09:42
@FRidh FRidh merged commit 5dc63e6 into NixOS:master Aug 13, 2017
@wizzup wizzup deleted the add-python-django-extensions branch September 2, 2017 07:02
@dotlambda
Copy link
Member

dotlambda commented Jul 8, 2018

@wizzup Do you still use the package? It's currently broken and I'd prefer to remove it if noone needs it.
EDIT: I've pushed an update to #43201.

@wizzup
Copy link
Contributor Author

wizzup commented Jul 9, 2018

I didn't use django anymore currently, feel free to remove it if it no longer working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants