pythonPackages.django_extensions : init at 1.8.1#27378
Conversation
3f4fdf0 to
dfc66e4
Compare
There was a problem hiding this comment.
please add a comment explaining why you disable tests.
There was a problem hiding this comment.
The test was failed at the time I create this PR, due to many dependencies are missing.
I fix this in next commit. Now pass all the tests.
There was a problem hiding this comment.
No, I won't. I don't think I have enough knowledge on python packaging.
I use django for my own personal project and found this project useful. Try to install it and think it would save time for other if the package is ready-to-use.
There was a problem hiding this comment.
The python packaging part can be handled by core maintainers. Often is more important to have someone, who knows how the library is supposed to work and have ways to use/test newer versions of it.
dfc66e4 to
8dad51b
Compare
There was a problem hiding this comment.
According to https://github.com/django-extensions/django-extensions/blob/b66dad0b4a3525a0f95977d198df87230907a154/setup.py#L130W six should probably be places in the propagatedBuildInputs.
There was a problem hiding this comment.
Thank a lot. I don't really understand build system (buildInputs, propagatedBuildInputs, nativeBuildInputs, etc). I try reading manual but doesn't fully get them.
Never have any problem with current expression, so I assume I wrote it correctly.
There was a problem hiding this comment.
For python they have the following semantics:
propagatedBuildInputs: all python packages, which should be available for consumers of this package or in other words runtime dependenciesbuildInputs: dependencies only needed to build the package, for python this is most often test dependencies likemockandpytest.nativeBuildInputs: if this package would be cross-compiled, host-native packages like compilers would be included here, however it is not that common for python packages to require them.
8dad51b to
bf76694
Compare
bf76694 to
d903b4f
Compare
|
I didn't use django anymore currently, feel free to remove it if it no longer working. |
Motivation for this change
To add django-extensions to python-modules
Things done
nix-shell -p nox --run "nox-review wip"nix-shell -I nixpkgs=/nix/nixpkgs -p python27Packages.django_extensions python36Packages.django_extensionsmanage.pywithshell_plusandgraph_models