Skip to content

duti: init at 1.5.4pre#27376

Merged
LnL7 merged 1 commit intoNixOS:masterfrom
matthewbauer:duti
Sep 14, 2017
Merged

duti: init at 1.5.4pre#27376
LnL7 merged 1 commit intoNixOS:masterfrom
matthewbauer:duti

Conversation

@matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Jul 14, 2017

I would init at 1.5.4, but sadly it doesn’t work on OS X 10.11+.

Mic92
Mic92 reviewed Jul 14, 2017
View reviewed changes
pkgs/os-specific/darwin/duti/default.nix Outdated
Copy link
Member

@Mic92 Mic92 Jul 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation.

Mic92
Mic92 reviewed Jul 14, 2017
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
Copy link
Member

@Mic92 Mic92 Jul 14, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we give up on the alphabetic ordering now?

Copy link
Member Author

@matthewbauer matthewbauer Jul 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try to find a better place for it. It used to be categorical then alphabetical, right? I guess it's a "tool" but I've never really liked the categories.

Copy link
Member Author

@matthewbauer matthewbauer Jul 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually should it be in the "Darwin" namespace? Not sure if that's only supposed to be core stuff though.

@Mic92 Mic92 added the 6.topic: darwin Running or building packages on Darwin label Jul 20, 2017
@LnL7 LnL7 added the 8.has: package (new) This PR adds a new package label Jul 20, 2017
LnL7
LnL7 reviewed Jul 20, 2017
View reviewed changes
pkgs/os-specific/darwin/duti/default.nix Outdated
Copy link
Member

@LnL7 LnL7 Jul 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The binary segfaults, we should fix the reference to CoreFoundation until #24693 is fixed.
(I suspect that's the issue)

@LnL7
Copy link
Member

LnL7 commented Jul 23, 2017

It looks ok after rebasing against may WIP changes.

@LnL7 LnL7 mentioned this pull request Jul 23, 2017
Merged
15 tasks
@matthewbauer matthewbauer changed the base branch from master to staging September 3, 2017 22:09
@matthewbauer matthewbauer changed the base branch from staging to master September 3, 2017 22:10
@LnL7
Copy link
Member

LnL7 commented Sep 13, 2017

@matthewbauer The CoreFoundation changes are in master now, should be good to merge now if you rebase.

@matthewbauer
duti: init at 1.5.4pre
9111b53 
I would init at 1.5.4, but sadly it doesn’t work on OS X 10.11+.
@matthewbauer
Copy link
Member Author

matthewbauer commented Sep 13, 2017

Ok I've rebased and no seg fault!

@LnL7 LnL7 merged commit 3161790 into NixOS:master Sep 14, 2017
@florianjacob florianjacob mentioned this pull request Sep 14, 2017
Merged
8 tasks
@matthewbauer matthewbauer deleted the duti branch February 22, 2019 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Mic92 left review comments

@copumpkin copumpkin Awaiting requested review from copumpkin

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

+1 more reviewer

@LnL7 LnL7 LnL7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LnL7 LnL7

Labels

6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matthewbauer @LnL7 @Mic92