Skip to content

dump_syms: fix building with LLVM 16 #273614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mweinelt merged 1 commit into from
Dec 11, 2023
Merged

dump_syms: fix building with LLVM 16 #273614

mweinelt merged 1 commit into from
Dec 11, 2023

Conversation

@ipetkov
Copy link
Contributor

@ipetkov ipetkov commented Dec 11, 2023

Description of changes

Builds were broken on Darwin with
#241692, so this applies the workaround from #166205

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ipetkov
Copy link
Contributor Author

ipetkov commented Dec 11, 2023

Result of nixpkgs-review run on aarch64-darwin 1

1 package built:
  • dump_syms

Result of nixpkgs-review run on x86_64-darwin 1

1 package built:
  • dump_syms

Result of nixpkgs-review run on x86_64-linux 1

Result of nixpkgs-review run on aarch64-linux 1

@nixos-discourse
Copy link

nixos-discourse commented Dec 11, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3076

onemoresuza
onemoresuza reviewed Dec 11, 2023
View reviewed changes
@ofborg ofborg bot requested a review from mweinelt December 11, 2023 22:36
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 11, 2023
wegank
wegank reviewed Dec 11, 2023
View reviewed changes
@ipetkov
dump_syms: fix building with LLVM 16
904913e 
Builds were broken on Darwin with
NixOS#241692, so this applies the
workaround from NixOS#166205
@mweinelt mweinelt merged commit c68839c into NixOS:master Dec 11, 2023
@ipetkov ipetkov deleted the dump_syms branch December 12, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wegank wegank wegank left review comments

@mweinelt mweinelt Awaiting requested review from mweinelt

+1 more reviewer

@onemoresuza onemoresuza onemoresuza left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ipetkov @nixos-discourse @wegank @onemoresuza @mweinelt