python3Packages.torch: gate NCCL with cudaSupport#273594
Merged
ConnorBaker merged 1 commit intoNixOS:masterfrom Dec 11, 2023
Merged
python3Packages.torch: gate NCCL with cudaSupport#273594ConnorBaker merged 1 commit intoNixOS:masterfrom
ConnorBaker merged 1 commit intoNixOS:masterfrom
Conversation
ConnorBaker
added
6.topic: darwin
github-actions
bot
added
the
6.topic: python
ConnorBaker
requested review from
Madouura,
SomeoneSerge and
natsukium
and removed request for
SomeoneSerge
Contributor
Author
|
@natsukium this should fix the error you were running into -- I'm able to eval now on my MacBook. Can you confirm the same? |
Contributor
Author
|
Note Template PR=273594; \
SYSTEM="aarch64-linux"; \
CUDA_SUPPORT="true"; \
CUDA_CAPABILITIES='[ "7.5" ]'; \
nixpkgs-review pr "$PR" \
--system "$SYSTEM" \
--no-shell \
--checkout commit \
--allow aliases \
--build-args "--max-jobs 1" \
--extra-nixpkgs-config "{
allowUnfree = true;
allowBroken = false;
cudaSupport = ${CUDA_SUPPORT:-false};
cudaCapabilities = ${CUDA_CAPABILITIES:-[]};
}"
|
SomeoneSerge
approved these changes
Dec 11, 2023
Contributor
SomeoneSerge
left a comment
SomeoneSerge
left a comment
There was a problem hiding this comment.
I don't think we have to wait for nixpkgs-review to merge this:
❯ nix eval github:ConnorBaker/nixpkgs/fix/pytorch-fix-gate-nccl-with-cudaSupport#legacyPackages.x86_64-darwin.python3Packages.torch.outPath
"/nix/store/qwsayvz14v0x7f06g2hmd6hsdssfgbrz-python3.11-torch-2.1.1"
❯ nix eval github:ConnorBaker/nixpkgs/fix/pytorch-fix-gate-nccl-with-cudaSupport#legacyPackages.aarch64-darwin.python3Packages.torch.outPath
"/nix/store/9g147agjr26wdc2g1a6b1c1477vz5qy0-python3.11-torch-2.1.1"Obviously the deeper issues with cudaPackages evaluation would still have to be diagnosed and addressed
delroth
added
the
12.approvals: 1
1 task
Contributor
|
Successfully created backport PR for |
ofborg
bot
added
10.rebuild-darwin: 101-500
Contributor
|
Git push to origin failed for release-23.11 with exitcode 1 |
2 similar comments
Contributor
|
Git push to origin failed for release-23.11 with exitcode 1 |
Contributor
|
Git push to origin failed for release-23.11 with exitcode 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This fixes an evaluation error on systems without CUDA support. Originally discovered in #256324 (comment).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.