python311Packages.huggingface-hub: 0.19.4 -> 0.20.2, python311Packages.transformers: 4.36.1 -> 4.36.2#273538
Merged
happysalada merged 2 commits intoNixOS:masterfrom Jan 16, 2024
Merged
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 11-100
Contributor
|
Result of 10 packages marked as broken and skipped:
46 packages failed to build:
120 packages built:
|
Contributor
|
I'm running a nixpkgs review I get a real failure in gradio, that will have to be handled |
Contributor
|
@pbsds would you have time to have a look at the failure ? Maybe just a simple update of gradio should work fine. |
Contributor
|
@misuzu ctranslate2 seems to be failing as well in case you have time to have a look. |
Contributor
|
@mweinelt faster-whisper seems to be failing on this PR. |
Contributor
|
Result of 10 packages marked as broken and skipped:
46 packages failed to build:
120 packages built:
|
Contributor
|
ctranslate2 seems to be updated to latest and this seems to cause breakage. I don't think there is anything I can do to move this forward, we have to wait at least a week for individual package maintainers to come forward and diagnose the failure. |
Member
Member
|
Also, jaxlib currently fails to build on master, so hard to say what builds and what doesn't. |
Contributor
|
I've retried all the ctranslate2 failures, and they all build. |
GaetanLepage
force-pushed
the
transformers
branch
2 times, most recently
from
bd4194d to
bbe390d
Compare
GaetanLepage
changed the title
Member
|
Bumping gradio seems to require a bit of work, i'll have look tonight. In the meanwhile try either applying gradio-app/gradio@24e0481 (maybe limited to |
Member
|
So, bumping nixpkgs/pkgs/development/python-modules/pydantic/default.nix Lines 28 to 29 in 99d03a4 It seems huggingface-hub is also already bumped on nixpkgs/pkgs/development/python-modules/huggingface-hub/default.nix Lines 15 to 16 in 99d03a4 I tried rebasing this PR to python-updates and bump gradio, but it seems the branch is currently failing eval deep inside Consider retargeting the |
13 tasks
Contributor
Author
|
Result of 10 packages marked as broken and skipped:
12 packages failed to build:
154 packages built:
|
GaetanLepage
force-pushed
the
transformers
branch
from
bbe390d to
c09b420
Compare
GaetanLepage
changed the title
Member
|
FYI, transformers v4.36.1 and huggingface-hub v0.19.4 are a part of #271586, soon to hit staging-next |
GaetanLepage
force-pushed
the
transformers
branch
from
c09b420 to
5e93851
Compare
GaetanLepage
force-pushed
the
transformers
branch
from
5e93851 to
14b2d59
Compare
Member
|
Result of 16 packages marked as broken and skipped:
10 packages failed to build:
20 packages built successfully:
Result of 4 packages marked as broken and skipped:
16 packages failed to build:
28 packages built successfully:
|
Contributor
Author
|
I am pretty sure that the other failing builds are due to unrelated broken dependencies. |
Member
|
Update the commit message, please. Besides this LGTM. |
GaetanLepage
force-pushed
the
transformers
branch
2 times, most recently
from
1c03826 to
caac79c
Compare
GaetanLepage
changed the title
Contributor
Author
Done ! Thank you for the review :) |
Contributor
|
the commit messages still talk about 0.18.0 , but latest master contains 0.19.2 |
GaetanLepage
force-pushed
the
transformers
branch
from
caac79c to
679c3a8
Compare
GaetanLepage
changed the title
Contributor
Author
You are right ! Corrected :) |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
cc @kira-bruneau @pashashocky @happysalada
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.