dnf-plugins-core: init at 4.4.3 by katexochen · Pull Request #272997 · NixOS/nixpkgs

katexochen · 2023-12-08T22:08:36Z

Description of changes

Things done

Add a 👍 reaction to pull requests you find important.

SuperSandro2000

Please follow the contributing guide when naming your commits.

pkgs/top-level/python-packages.nix

pkgs/top-level/all-packages.nix

pkgs/development/python-modules/dnf4/wrapper.nix

SuperSandro2000 · 2023-12-10T20:39:15Z

pkgs/development/python-modules/dnf4/wrapper.nix

Suggested change

mkdir -p $out

cp -R ${dnf4-unwrapped}/* $out/

mkdir -p $py

cp -R ${dnf4-unwrapped.py}/* $py/

mkdir -p $man

cp -R ${dnf4-unwrapped.man}/* $man/

mkdir -p $out $py $man

cp -R ${dnf4-unwrapped}/* $out/

cp -R ${dnf4-unwrapped.py}/* $py/

cp -R ${dnf4-unwrapped.man}/* $man/

also we should symlink instead

I couldn't get this running with symlinks, it keeps failing with permission errors:

post-installation fixup chmod: changing permissions of '/nix/store/9mvni7wqni9q6nv5cff32w9njz679xl8-dnf4-4.18.2': Operation not permitted chmod: changing permissions of '/nix/store/9mvni7wqni9q6nv5cff32w9njz679xl8-dnf4-4.18.2/lib': Operation not permitted chmod: changing permissions of '/nix/store/9mvni7wqni9q6nv5cff32w9njz679xl8-dnf4-4.18.2/lib/systemd': Operation not permitted chmod: changing permissions of '/nix/store/9mvni7wqni9q6nv5cff32w9njz679xl8-dnf4-4.18.2/lib/systemd/system': Operation not permitted ....

then we keep the cp for now unless someone else finds a good solution

pkgs/development/python-modules/dnf4/default.nix

pkgs/development/python-modules/dnf-plugins-core/default.nix

katexochen · 2023-12-13T22:35:31Z

Thanks for your review.

Please follow the contributing guide when naming your commits.

I'm sorry, I don't get what's wrong with the name of my commit, could you please give me a hint?

SuperSandro2000 · 2023-12-15T00:23:50Z

I'm sorry, I don't get what's wrong with the name of my commit, could you please give me a hint?

First of all, I should revisit my reply template and add the link to the headline directly. 😅

Also I've just noticed that it kinda turned into a linktree and I also couldn't find what I was searching for on the fast but essentially each package should get it's own commit and that is written somewhere there 😂

SuperSandro2000

other than one commit for each package, I don't have immediate feedback right now.

pkgs/development/python-modules/dnf-plugins-core/default.nix

dblsaiko

some small things :^)

pkgs/development/python-modules/dnf-plugins-core/default.nix

pkgs/top-level/all-packages.nix

pkgs/development/python-modules/dnf-plugins-core/default.nix

malt3

Tested successfully on Linux amd64

pbsds

Result of nixpkgs-review pr 272997 run on x86_64-linux 1

6 packages built:

python310Packages.dnf4
python310Packages.dnf4.man
python310Packages.dnf4.py
python311Packages.dnf4
python311Packages.dnf4.man
python311Packages.dnf4.py

Weird, I had to build python3Packages.dnf-plugins-core and dnf4 manually. Did ofborg do a booboo?

Looks mostly good to me, just a nit.

pkgs/development/python-modules/dnf4/default.nix

pbsds · 2023-12-23T14:01:33Z

Result of nixpkgs-review pr 272997 run on x86_64-linux 1

6 packages built:

python310Packages.dnf4
python310Packages.dnf4.man
python310Packages.dnf4.py
python311Packages.dnf4
python311Packages.dnf4.man
python311Packages.dnf4.py

LGTM, but the ofborg eval is still weird...

@ofborg build python310Packages.dnf4 python310Packages.dnf4.passthru.tests python311Packages.dnf4 python311Packages.dnf4.passthru.tests python310Packages.dnf-plugins-core python310Packages.dnf-plugins-core.passthru.tests python311Packages.dnf-plugins-core python311Packages.dnf-plugins-core.passthru.tests dnf4 dnf4.passthru.tests

katexochen · 2023-12-23T15:58:53Z

LGTM, but the ofborg eval is still weird...

Yes, it's indeed a bit weird. But I'm not sure what to do about it.

pbsds · 2023-12-23T18:05:06Z

nixpkgs-review would discover it if it didn't use the ofborg eval

$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f . -qaP --xml --out-path --show-trace --no-allow-import-from-derivation --meta  | grep -E 'attrPath=".*dnf'
  <item attrPath="dnf-plugins-core" name="dnf-plugins-core-4.4.3" outputName="out" pname="dnf-plugins-core" system="x86_64-linux" version="4.4.3">
  <item attrPath="dnf4" name="dnf4-4.18.2" outputName="out" pname="dnf4" system="x86_64-linux" version="4.18.2">
  <item attrPath="dnf5" name="dnf5-5.1.8" outputName="out" pname="dnf5" system="x86_64-linux" version="5.1.8">
  <item attrPath="ifdnfc" name="ifdnfc-2016-03-01" outputName="out" pname="ifdnfc" system="x86_64-linux" version="2016-03-01">
  <item attrPath="python310Packages.libdnf" name="libdnf-0.72.0" outputName="py" pname="libdnf" system="x86_64-linux" version="0.72.0">
  <item attrPath="libdnf" name="libdnf-0.72.0" outputName="out" pname="libdnf" system="x86_64-linux" version="0.72.0">
  <item attrPath="python311Packages.libdnf" name="libdnf-0.72.0" outputName="py" pname="libdnf" system="x86_64-linux" version="0.72.0">
  <item attrPath="microdnf" name="microdnf-3.10.0" outputName="out" pname="microdnf" system="x86_64-linux" version="3.10.0">
  <item attrPath="python310Packages.dnf-plugins-core" name="python3.10-dnf-plugins-core-4.4.3" outputName="out" pname="python3.10-dnf-plugins-core" system="x86_64-linux" version="4.4.3">
  <item attrPath="python310Packages.dnf4" name="python3.10-dnf4-4.18.2" outputName="out" pname="python3.10-dnf4" system="x86_64-linux" version="4.18.2">
  <item attrPath="python310Packages.dnfile" name="python3.10-dnfile-0.14.1" outputName="out" pname="python3.10-dnfile" system="x86_64-linux" version="0.14.1">
  <item attrPath="python311Packages.dnf-plugins-core" name="python3.11-dnf-plugins-core-4.4.3" outputName="out" pname="python3.11-dnf-plugins-core" system="x86_64-linux" version="4.4.3">
  <item attrPath="python311Packages.dnf4" name="python3.11-dnf4-4.18.2" outputName="out" pname="python3.11-dnf4" system="x86_64-linux" version="4.18.2">
  <item attrPath="python311Packages.dnfile" name="python3.11-dnfile-0.14.1" outputName="out" pname="python3.11-dnfile" system="x86_64-linux" version="0.14.1">
  <item attrPath="vimPlugins.mkdnflow-nvim" name="vimplugin-mkdnflow.nvim-2023-11-28" outputName="out" pname="vimplugin-mkdnflow.nvim" system="x86_64-linux" version="2023-11-28">

Should also show up on search.nixos.com.

github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 8, 2023

SuperSandro2000 reviewed Dec 10, 2023

View reviewed changes

katexochen force-pushed the dnf4/init-plugins branch 2 times, most recently from 8738b4f to 63f9d2e Compare December 13, 2023 22:24

katexochen requested a review from SuperSandro2000 December 14, 2023 09:26

SuperSandro2000 reviewed Dec 15, 2023

View reviewed changes

pkgs/development/python-modules/dnf-plugins-core/default.nix Outdated Show resolved Hide resolved

katexochen force-pushed the dnf4/init-plugins branch 2 times, most recently from 611b6ac to aadedbf Compare December 16, 2023 18:38

katexochen requested a review from SuperSandro2000 December 16, 2023 19:01

SuperSandro2000 approved these changes Dec 18, 2023

View reviewed changes

delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 18, 2023

katexochen requested a review from malt3 December 19, 2023 07:33

dblsaiko suggested changes Dec 21, 2023

View reviewed changes

pkgs/development/python-modules/dnf-plugins-core/default.nix Outdated Show resolved Hide resolved

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved

katexochen force-pushed the dnf4/init-plugins branch from aadedbf to fcd4e55 Compare December 21, 2023 11:03

katexochen requested a review from dblsaiko December 21, 2023 11:05

dblsaiko reviewed Dec 21, 2023

View reviewed changes

pkgs/development/python-modules/dnf-plugins-core/default.nix Outdated Show resolved Hide resolved

delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 21, 2023

katexochen force-pushed the dnf4/init-plugins branch from fcd4e55 to fa5e2a5 Compare December 21, 2023 11:42

katexochen requested a review from dblsaiko December 21, 2023 11:45

malt3 approved these changes Dec 21, 2023

View reviewed changes

dblsaiko approved these changes Dec 21, 2023

View reviewed changes

delroth added the 12.approvals: 3+ This PR was reviewed and approved by three or more persons. label Dec 21, 2023

pbsds reviewed Dec 21, 2023

View reviewed changes

pkgs/development/python-modules/dnf4/default.nix Outdated Show resolved Hide resolved

katexochen added 3 commits December 22, 2023 10:43

python3Packages.dnf4: don't wrap, add py output

168f0d5

dnf-plugins-core: init at 4.4.3

64365bb

dnf4: wrap with plugins

d3ecf90

katexochen force-pushed the dnf4/init-plugins branch from fa5e2a5 to d3ecf90 Compare December 22, 2023 09:44

katexochen requested a review from pbsds December 22, 2023 09:52

delroth removed the 12.approvals: 3+ This PR was reviewed and approved by three or more persons. label Dec 22, 2023

pbsds merged commit 29e8733 into NixOS:master Dec 23, 2023

katexochen deleted the dnf4/init-plugins branch December 23, 2023 19:13

infinisil mentioned this pull request Jan 4, 2024

lib.callPackageWith: Use abort again instead of throw and fix evaluation errors caused by it #278777

Merged

-    mkdir -p $out
-    cp -R ${dnf4-unwrapped}/* $out/
-    mkdir -p $py
-    cp -R ${dnf4-unwrapped.py}/* $py/
-    mkdir -p $man
-    cp -R ${dnf4-unwrapped.man}/* $man/
+    mkdir -p $out $py $man
+    cp -R ${dnf4-unwrapped}/* $out/
+    cp -R ${dnf4-unwrapped.py}/* $py/
+    cp -R ${dnf4-unwrapped.man}/* $man/

Uh oh!

Conversation

katexochen commented Dec 8, 2023

Description of changes

Things done

Uh oh!

SuperSandro2000 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SuperSandro2000 Dec 10, 2023

Choose a reason for hiding this comment

Uh oh!

katexochen Dec 13, 2023

Choose a reason for hiding this comment

Uh oh!

SuperSandro2000 Dec 15, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

katexochen commented Dec 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SuperSandro2000 commented Dec 15, 2023

Uh oh!

SuperSandro2000 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dblsaiko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

malt3 left a comment

Choose a reason for hiding this comment

Uh oh!

pbsds left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pbsds commented Dec 23, 2023

Uh oh!

katexochen commented Dec 23, 2023

Uh oh!

pbsds commented Dec 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

katexochen commented Dec 13, 2023 •

edited

Loading