hareThirdParty.hare-json: unstable-2023-09-21 -> unstable-2023-03-13

[onemoresuza]

Description of changes

• hareThirdParty.hare-json: move to pkgs/development/hare-third-party
• hareThirdParty.hare-json: refactor configurePhase into makeFlags
• hareThirdParty.hare-json: unstable-2023-09-21 -> unstable-2023-03-13

Ready hareThirdParty.hare-json to changes to be brought by #271476.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[starzation]

Please keep commit message with this prefix hareThirdParty.hare-json:

[onemoresuza]

Please keep commit message with this prefix hareThirdParty.hare-json:

Thanks for catching my mistake. Rebased the commit messages to start with hareThirdParty.hare-json.

[pbsds]

#272136 #271476 is merged, please rebase

[onemoresuza]

Rebase against master after #271476.

I've left the file location change as a separate commit, based on what is done
when changing a package from the Category Hierarchy to
pkgs/by-name. Is this correct or should such commit be squashed?

[pbsds]

Result of nixpkgs-review pr 272136 run on x86_64-linux 1

1 package built:

• hareThirdParty.hare-json

LGTM, thanks :)

[pbsds]

Is this correct or should such commit be squashed?

In general, splitting each change into separate commits makes review far easier. Github/git is usually also better able to create meaningful diff views when each change is smaller. I know however there are other committers who prefer the opposite.