Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logseq: 0.9.20 -> 0.10.0 #272126

Merged
merged 1 commit into from
Dec 5, 2023
Merged

logseq: 0.9.20 -> 0.10.0 #272126

merged 1 commit into from
Dec 5, 2023

Conversation

shanesveller
Copy link
Contributor

@shanesveller shanesveller commented Dec 4, 2023

Description of changes

https://github.com/logseq/logseq/releases/tag/0.10.0

Things done

This was my first time trying out nixpkgs-update - please let me know if there are any mistakes or gotchas I should be aware of, so I can do better going forward.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@shanesveller
Copy link
Contributor Author

Result of nixpkgs-review pr 272126 run on x86_64-linux 1

1 package built:
  • logseq

@shanesveller
Copy link
Contributor Author

I'm not able to immediately confirm the update is working as intended. I haven't bisected it further, but my NixOS environment broke for running Logseq somewhere between 2023-11-24 and 2023-12-01, and so my NixOS build using the nixos-23.11 input is not able to successfully run Logseq, whether or not it includes these changes. I get a miscolored window that doesn't render text or properly display UI elements, but seems to have the correct background and react to some keyboard inputs.

I'll take it out of draft in case a reviewer is not affected by my issues.

@shanesveller shanesveller marked this pull request as ready for review December 4, 2023 23:03
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 5, 2023
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works correctly for me (on sway, both wayland and xwayland).

@NickCao
Copy link
Member

NickCao commented Dec 5, 2023

I get a miscolored window that doesn't render text or properly display UI elements, but seems to have the correct background and react to some keyboard inputs.

This could be related to #244742

@NickCao NickCao merged commit b4a76ab into NixOS:master Dec 5, 2023
@shanesveller shanesveller deleted the shanesveller/logseq-0.10.0 branch December 5, 2023 14:27
@shanesveller
Copy link
Contributor Author

This could be related to #244742

That definitely sounds plausible, thanks very much for the pointer! 🍻

@jontyms
Copy link

jontyms commented Dec 6, 2023

I get a miscolored window that doesn't render text or properly display UI elements, but seems to have the correct background and react to some keyboard inputs.

I deleted the files in ~/.config/Logseq/GPUCache and it started working

(I am on 0.9.20 so the bug is not related to 0.10.0)

@schmittlauch schmittlauch mentioned this pull request Feb 1, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants