Skip to content

Elisp updates#272032

Closed
AndersonTorres wants to merge 4 commits intoNixOS:masterfrom
atorres1985-contrib:elisp
Closed

Elisp updates#272032
AndersonTorres wants to merge 4 commits intoNixOS:masterfrom
atorres1985-contrib:elisp

Conversation

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Dec 4, 2023

Description of changes

Triggered by #272019

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres AndersonTorres marked this pull request as ready for review December 4, 2023 13:03
@github-actions github-actions bot added the 6.topic: emacs Text editor label Dec 4, 2023
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Dec 4, 2023
ghost
ghost suggested changes Dec 5, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like it should target staging and ofborg has not triggered any builds for these changes.

@leungbk
Copy link
Member

leungbk commented Dec 5, 2023

this looks like it should target staging and ofborg has not triggered any builds for these changes.

In the past, we've had permission to bypass staging and target master directly since these rebuilds are for Elisp packages.

@AndersonTorres
Copy link
Member Author

AndersonTorres commented Dec 5, 2023 •
edited
Loading

Emacs Lisp packages are a "mass rebuild" because they are legion, not because they are reverse dependencies of the whole system.

@AndersonTorres
Copy link
Member Author

AndersonTorres commented Dec 8, 2023

Since that idea of throwing Emacs on staging, I will close this.

#272984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndersonTorres @leungbk