tree-sitter-grammar: ensure enough space when updating id of shared lib on Darwin

[c4710n]

This PR is trying to fix the error when updating install names on Darwin:

error: install_name_tool: changing install names or rpaths can't be redone for: [...]
(the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)

This technique is also used by:

• ghostscript
• lpsolve
• suitesparse
• ...

It should be safe to add it. I have tested on x86_64-darwin.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[ghost]

change looks good -- one nit described inline.
a couple of things:

1. how do i build this on darwin to reproduce this error?
2. i started to run a nix run .\#nixpkgs-review -- pr 271974 from the nixpkgs src root and it seems like this causes 1.4k rebuilds, so the change might need to target the staging branch -- i've never done this but there are some pointers in CONTRIBUTING.md

[c4710n]

Hey, @a-n-n-a-l-e-e Thanks for your guidance.

I have:

• moved the change to env variables
• changed the target to staging branch

And, I changed the title of PR and commit message to more descriptive ones.

---

how do i build this on darwin to reproduce this error?

This error won't occur if we use the output directly. But when we want to further process the output, the error will occur. For example, let's build tree-sitter-clojure:

$ nix build .#legacyPackages.x86_64-darwin.tree-sitter-grammars.tree-sitter-clojure

# create a lab
$ mkdir lab && cd lab

$ cp ../result/parser  ./parser

# changes identification name of the dynamic shared library to a very long name
$ install_name_tool \
  -id /nix/store/dwh6vsxb1mr2rjzmr11hn51ih76ilxdj-tree-sitter-grammars/lib/libtree-sitter-clojure.dylib \
  ./parser
error: install_name_tool: changing install names or rpaths can't be redone for: ./parser (for architecture x86_64) because larger updated load commands do not fit (the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)

In short, tree-sitter-grammar isn't broken, but it doesn't support changing the identification name of a dynamic shared library to a very long name, which is necessary in my case. This PR is trying to add this kind of support, without effecting others.

[ghost]

i see -- could this be solved by using overrideAttrs to modify the build locally? doing something like ...

nix build --impure --expr \
'with import ./. {}; tree-sitter-grammars.tree-sitter-clojure.overrideAttrs(prev: { env = (prev.env or {} ) // { NIX_LDFLAGS = "-headerpad_max_install_names"; };})'

or

nix build --impure --expr \
'with import <nixpkgs> {}; tree-sitter-grammars.tree-sitter-clojure.overrideAttrs(prev: { env = (prev.env or {} ) // { NIX_LDFLAGS = "-headerpad_max_install_names"; };})'

that wouldn't require updating nixpkgs?

---

i am not sure if the migration to staging went well -- it seems like perhaps a bunch of people got pulled and might ask to close the PR (can open a new one). I am not entirely sure as i've never delt with this on nixkgs but this link might be helpful:
https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#something-went-wrong-and-a-lot-of-people-were-pinged

[c4710n]

Thanks, @a-n-n-a-l-e-e. Your solution works, it's better to scope special code to my own case.

I'll close this PR. Thank you, again.