buildPython*: migrate from buildPython* { inherit stdenv; ...; } to (buildPython*.override { inherit stdenv; }) { ... }#271947
Closed
ShamrockLee wants to merge 12 commits intoNixOS:masterfrom
Closed
Conversation
github-actions
bot
added
6.topic: python
13 tasks
ofborg
bot
added
10.rebuild-darwin: 0
ShamrockLee
force-pushed
the
python-function-override-migrate
branch
4 times, most recently
from
b853bd0 to
c848291
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
wegank
added
the
2.status: merge conflict
wegank
added
the
2.status: stale
Fix `makeOverridablePythonPackage` in python-package-base.nix
and unshadow `buildPython*.override`.
This makes it possible to override the dependencies of buildPython*.
E.g., `buildPythonPackage.override { unzip = unzip-custom; }`
returns a derived version of `buildPythonPackage` with
the `unzip` package overridden with `unzip-custom`.
Guide users to use `buildPython*.override` to customize stdenv instead of `buildPython*` with a warning message. Users can remedy the warning by using an overridden versi,on of `buildPython*`.
…with bulidPython*.override
ShamrockLee
force-pushed
the
python-function-override-migrate
branch
from
c848291 to
57edbc9
Compare
stale
bot
removed
the
2.status: stale
github-actions
bot
removed
6.topic: nixos
ofborg
bot
removed
the
2.status: merge conflict
wegank
added
the
2.status: merge conflict
nixpkgs-ci
bot
added
the
2.status: stale
Contributor
Author
|
Surpassed by PR #476401 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The
buildPython* { inherit stdenv; ...; }will be impossible/unfeasible when taking fixed-point arguments (buildPython* (finalAttrs: { ...; })).This PR does tree-wide migration to the
(buildPython*.override { inherit stdenv; ...; }) { ... }style of customize stdenv specification, and print out a warning whenstdenv = ;is passed directly intobuildPython*.Depends on #271762, will be shorter once that PR gets merged.
Things done
nixos-install-tools)nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.