Skip to content

[Backport release-23.11] gcc6: don’t link libstdc++ to CoreFoundation#271153

Merged
wegank merged 1 commit intorelease-23.11from
backport-267773-to-release-23.11
Nov 30, 2023
Merged

[Backport release-23.11] gcc6: don’t link libstdc++ to CoreFoundation#271153
wegank merged 1 commit intorelease-23.11from
backport-267773-to-release-23.11

Conversation

@github-actions
Copy link
Contributor

Bot-based backport to release-23.11, triggered by a label in #267773.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

Using flat namespaces causes libstdc++ to link CoreFoundation, but
that fails after #265102. Since CoreFoundation is not actually needed,
disable flat namespaces to avoid linking it unnecessarily.

Disabling flat namespaces matches the behavior of newer versions of
libstdc++ (GCC 7+) when building for newer Darwin hosts (10.5+).

(cherry picked from commit 647b2db)
@github-actions github-actions bot requested a review from a user November 30, 2023 08:54
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 30, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 30, 2023
@wegank wegank merged commit 9dfad39 into release-23.11 Nov 30, 2023
@wegank wegank deleted the backport-267773-to-release-23.11 branch November 30, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants