Merged
Conversation
added 2 commits
May 21, 2014 09:36
lib/maintainers.nix
Outdated
Member
There was a problem hiding this comment.
nitpick: the list of maintainers is sorted alphabetically
Member
|
Thanks for packaging this, I didn't test it yet, but apart from some issues with sticking to conventions it looks good! |
Author
|
Just noticed that some of the replacements for /bin/bash screw up at least the apt-task. Don't merge yet :) |
Author
|
the modules in share/ansible are executed on the remote host so we shouldn't wrap them. I had to modify python-modules/generic to allow for this. Is there a better approach? |
vcunat
added a commit
that referenced
this pull request
Jun 11, 2014
Conflicts (trivial): lib/maintainers.nix
Member
|
Your solution looks good to me. |
Janik-Haag
added
the
12.first-time contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.