Conversation
|
Previous PR: #140301 |
Mic92
left a comment
There was a problem hiding this comment.
I guess we could try this out. Hopefully not too many commits go in the checkout action etc.
|
If we're going to merge this we may as well pin all of the actions so the dependabot updates are consistent. |
@zowoq Whoops, turns out I've manually bumped the version tags to the latest tag with that commit ID. The build won't change ( |
dc836d2 to
77d5afc
Compare
For reproducibility.
Command:
```shell
for file in .github/workflows/*.y*ml; do
npx pin-github-action --comment=' {ref}' "$file"
done
```
Then had to manually replace all the versions with accurate specifiers
(for example, "v4" → "v4.1.1" in case of `actions/checkout`).
|
Ok. Let's try this out. |
Description of changes
Improves reproducibility of CI tasks, especially since actions often move their tags, resulting in
foo@vNbeing equivalent tofoo@vN.*.*. This is not rare - as you can see from the PR, most of the pinned actions have been moved. For example,actions/checkout@v4has been moved to v4.1.1.Dependabot knows how to update pinned dependencies and their comments, so there should be no overhead from this change.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.