nixos-rebuild: remove manpage hint on feature that is not merged#270403
Merged
JulienMalka merged 1 commit intoNixOS:masterfrom Nov 27, 2023
Merged
nixos-rebuild: remove manpage hint on feature that is not merged#270403JulienMalka merged 1 commit intoNixOS:masterfrom
JulienMalka merged 1 commit intoNixOS:masterfrom
Conversation
This is a hint that mentions the feature NixOS#105910 but that is not yet merged. This is very confusing and since it there is no progress with that merge we should remove the reference
github-actions
bot
added
the
6.topic: nixos
ThinkChaos
approved these changes
Nov 27, 2023
delroth
added
the
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a hint that mentions the feature #105910 but that is not yet merged. This is very confusing and since it there is no progress with that merge we should remove the reference. I messed it up when splitting up the MR into two... Sorry!
Description of changes
As @ThinkChaos mentioned in #105910 (comment) the list-generations man-page mentiones the feature from the MR. Since that is not merged, it is very confusing and should be removed...
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.