Conversation
There was a problem hiding this comment.
This change is missing from 15 but in #194634
#185766
verify still needed; add a regression passthru test?
appears to be no longer needed; libc++abi.so didn't seem to be linked against older libc++abi on non-darwin anyways (where the default stdenv wasn't LLVM based) and now we unconditionally use the clang from the same package set which has libcxx set to null and thus doesn't try to link in any libc++abi
There was a problem hiding this comment.
This is enableGoldPlugin ? libbfd.hasPluginAPI in 15 because b9a9dfc wasn't ported to git
|
I went through all the diffs and there are no changes missing for 15, only changes missing from _git |
228a2fa to
d29bf06
Compare
Works after changing `git/default.nix` to use `gitRelease` instead of `officialRelease`
Wont update the version attr
```
, gitRelease ? {
version = "15.0.0";
rev = "a5640968f2f7485b2aa4919f5fa68fd8f23e2d1f";
rev-version = "unstable-2022-26-07";
sha256 = "1sh5xihdfdn2hp7ds3lkaq1bfrl4alj36gl1aidmhlw65p5rdvl7";
}
```
There are no maintainers for this as shown by it still being at llvm 15 and it's unnecessary work to apply all changes to it. It has not been a git version for a long time and often lags behind the latest stable llvm
d29bf06 to
b84c55e
Compare
|
|
|
Probably shouldn't kill |
There are no maintainers for this as shown by it still being at llvm 15 and it's unnecessary work to apply all changes to it.
It has not been a git version for a long time and often lags behind the latest stable llvm
Here are all the differences between the current base(15) of _git and 15 https://gist.github.com/Artturin/c39265ecaeea523cd7224fc7b7632371
We should do this because it eases (my) work on deduplicating llvmPackages, after more of it is deduplicated then we could reconsider adding this back but for now it's just a burden.
Any user who wants to use a git release can use the
gitReleaseargument in 13+Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.