Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.pgvector: 0.2.3 -> 0.2.4 #269751

Merged
merged 2 commits into from
Nov 26, 2023
Merged

python311Packages.pgvector: 0.2.3 -> 0.2.4 #269751

merged 2 commits into from
Nov 26, 2023

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Nov 24, 2023

Diff: pgvector/pgvector-python@refs/tags/v0.2.3...v0.2.4

Changelog: https://github.com/pgvector/pgvector-python/blob/refs/tags/v0.2.4/CHANGELOG.md

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@fabaff fabaff changed the title python311Packages.pgvector: 0.2.3 -> 0.2.4, python311Packages.pgvector: 0.2.3 -> 0.2.4 Nov 24, 2023
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Nov 25, 2023
@ofborg ofborg bot requested a review from natsukium November 25, 2023 02:37
natsukium
natsukium approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

pkgs/development/python-modules/sqlmodel/default.nix
];

propagatedBuildInputs = [
pydantic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 fastapi/sqlmodel#632

@natsukium
Copy link
Member

natsukium commented Nov 25, 2023 •
edited
Loading

pgvector on aarch64-darwin fails because of darwin sandbox.

Result of nixpkgs-review pr 269751 at 15b9f1b run on aarch64-darwin 1

2 packages failed to build:
2 packages built successfully:
  • python310Packages.sqlmodel
  • python311Packages.sqlmodel

Result of nixpkgs-review pr 269751 at 15b9f1b run on x86_64-linux 1

4 packages built successfully:
  • python310Packages.pgvector
  • python310Packages.sqlmodel
  • python311Packages.pgvector
  • python311Packages.sqlmodel

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 25, 2023
@natsukium natsukium merged commit 5977ed2 into NixOS:master Nov 26, 2023
28 checks passed
@fabaff fabaff deleted the pgvector-bump branch November 26, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium approved these changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabaff @natsukium @delroth