buildMozillaMach: fix crashes due to statically linked libstdc++#269680
Merged
vcunat merged 1 commit intoNixOS:release-23.05from Nov 24, 2023
Merged
buildMozillaMach: fix crashes due to statically linked libstdc++#269680vcunat merged 1 commit intoNixOS:release-23.05from
vcunat merged 1 commit intoNixOS:release-23.05from
Conversation
The cc-wrapper currently only supplies libstdcc++.a in its search paths, which causes bugs described as described in the upstream mozbz issue. Work around this by passing a search path that includes the dynamically linked version. Upstream-Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1861365 Co-Authored-By: Sergei Trofimovich <slyich@gmail.com> Closes: NixOS#269571
bew
reviewed
Nov 24, 2023
| LDFLAGS = "-Wl,-rpath,${placeholder "out"}/lib/${binaryName}"; | ||
| }; | ||
|
|
||
| # workaround for clang statically linking against libstdc++ |
Contributor
There was a problem hiding this comment.
Might be worth mentioning why this is a problem and needs a workaround, and/or link to the issue
Member
Author
There was a problem hiding this comment.
We will immediately revert this commit in staging-next-23.05, since the proper fix is in #267737.
ofborg
bot
requested review from
SuperSandro2000,
edolstra,
jopejoe1,
lovesegfault,
nbp,
squalus and
vcunat
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
OK, let's do it the quick way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cc-wrapper currently only supplies libstdcc++.a in its search paths, which causes bugs described as described in the upstream mozbz issue.
Work around this by passing a search path that includes the dynamically linked version.
Upstream-Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1861365
Closes: #269571
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.