Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thelounge: migrate to prefetch-yarn-deps #269310

Merged
merged 1 commit into from
Mar 25, 2024
Merged

thelounge: migrate to prefetch-yarn-deps #269310

merged 1 commit into from
Mar 25, 2024

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Nov 22, 2023 •
edited
Loading

Description of changes

#240174

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey Stunkymonkey mentioned this pull request Nov 22, 2023
Closed
39 tasks
@ofborg ofborg bot requested review from RaitoBezarius and winterqt November 23, 2023 02:59
@Stunkymonkey
Copy link
Contributor Author

Result of nixpkgs-review pr 269310 run on x86_64-linux 1

1 package built:
  • thelounge

@winterqt
Copy link
Member

winterqt commented Dec 9, 2023

Just going to re-run the eval since it's been a bit of time since they ran.
@ofborg eval

@Stunkymonkey
Copy link
Contributor Author

reminder @winterqt

philiptaron
philiptaron approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 269310 run on x86_64-linux 1

1 package built:
  • thelounge

I ran the thing and it appeared to work.

@Stunkymonkey
Copy link
Contributor Author

ping @winterqt and @RaitoBezarius ? can I merge this one day?

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 8, 2024
@Stunkymonkey Stunkymonkey merged commit 383125f into NixOS:master Mar 25, 2024
1 check passed
@Stunkymonkey Stunkymonkey deleted the thelounge-migrate-prefetch-yarn-deps branch March 25, 2024 19:55
@philiptaron
Copy link
Contributor

💪🏻

Thanks for moving it forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philiptaron philiptaron philiptaron approved these changes

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

@winterqt winterqt Awaiting requested review from winterqt

@lilyinstarlight lilyinstarlight Awaiting requested review from lilyinstarlight

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stunkymonkey @winterqt @philiptaron @wegank