Skip to content

readline: 8.2p1 -> 8.2p7#269128

Merged
marsam merged 1 commit intoNixOS:stagingfrom
trofi:readline-update
Nov 25, 2023
Merged

readline: 8.2p1 -> 8.2p7#269128
marsam merged 1 commit intoNixOS:stagingfrom
trofi:readline-update

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Nov 22, 2023 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@marsam
Copy link
Contributor

marsam commented Nov 24, 2023 •
edited
Loading

@GrahamcOfBorg eval

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 25, 2023
@marsam marsam merged commit 8235ec1 into NixOS:staging Nov 25, 2023
@trofi trofi deleted the readline-update branch November 25, 2023 14:27
@Ericson2314
Copy link
Member

Ericson2314 commented Jan 10, 2024 •
edited
Loading

We need this for MinGW support, and Nix build with MinGW needs readline.

@github-actions github-actions bot mentioned this pull request Jan 10, 2024
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024

Successfully created backport PR for staging-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@marsam marsam marsam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trofi @marsam @Ericson2314