Skip to content

gcc: fix missing atomic ops errors on risc-v #268067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fgaz wants to merge 1 commit into from
Closed

gcc: fix missing atomic ops errors on risc-v #268067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkgs/development/compilers/gcc/patches/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,15 @@ in
}.${majorVersion} or [])


### RISC-V


# https://gcc.gnu.org/git?p=gcc.git;a=commit;h=f797260adaf52bee0ec0e16190bbefbe1bfc3692
Copy link

@ghost ghost Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What release is this commit part of? git tag --contains doesn't report any.

Copy link
Member Author

@fgaz fgaz Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None yet as far as I can see

Copy link
Member Author

@fgaz fgaz Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out gcc 13 includes the patch

Copy link

@ghost ghost Nov 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then why not just use

Copy link
Member Author

@fgaz fgaz Nov 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's perfect!

I thought that upgrade was still far off, good to know that's not the case!

# Fixes errors like:
# ld: [...]: undefined reference to `__atomic_exchange_1'
++ optional (targetPlatform.isRiscV && is12) ./riscv-inline-subword-atomic-ops.patch


## Windows

# Obtain latest patch with ../update-mcfgthread-patches.sh
Expand Down
Loading