Skip to content

python2/mk-python-derivation: disable catchConflictsHook#268027

Merged
RaitoBezarius merged 1 commit intoNixOS:masterfrom
K900:py2-hack
Nov 17, 2023
Merged

python2/mk-python-derivation: disable catchConflictsHook#268027
RaitoBezarius merged 1 commit intoNixOS:masterfrom
K900:py2-hack

Conversation

@K900
Copy link
Contributor

@K900 K900 commented Nov 17, 2023

It's broken on Py2. Hopefully people still using 2 know what they're doing?

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

It's broken on Py2. Hopefully people still using 2 know what they're doing?
@K900 K900 requested a review from FRidh as a code owner November 17, 2023 04:49
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 17, 2023
@K900
Copy link
Contributor Author

K900 commented Nov 17, 2023

Should probably be replaced with a proper fix, but #267669 has to go through staging.

@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 17, 2023
@RaitoBezarius RaitoBezarius merged commit 80063d0 into NixOS:master Nov 17, 2023
@abathur
Copy link
Member

abathur commented Nov 17, 2023

A little late, but for posterity:

Result of nixpkgs-review pr 268027 run on x86_64-darwin 1

9 packages marked as broken and skipped:
  • kicadAddons.kikit
  • kicadAddons.kikit-library
  • kikit
  • kikit.dist
  • neard
  • neard.dev
  • platypus
  • resholve
  • resholve.dist
18 packages built:
  • bash-preexec
  • bashup-events32
  • bashup-events44
  • bats
  • cvs2svn
  • cvs2svn.dist
  • git-ftp
  • ix
  • locate-dominating-file
  • mons
  • msmtp
  • packcc
  • pdf2odt
  • pypy (pypy2 ,pypy27)
  • pypy3 (pypy39)
  • pypy310
  • shunit2
  • yadm

@K900 K900 deleted the py2-hack branch July 27, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants