Skip to content

Comments

vector: 0.34.0 → 0.34.1#267981

Merged
happysalada merged 1 commit intoNixOS:masterfrom
jpds:vector-0.34.1
Nov 17, 2023
Merged

vector: 0.34.0 → 0.34.1#267981
happysalada merged 1 commit intoNixOS:masterfrom
jpds:vector-0.34.1

Conversation

@jpds
Copy link
Contributor

@jpds jpds commented Nov 16, 2023

Description of changes

Regression fix: vectordotdev/vector@v0.34.0...v0.34.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wegank
Copy link
Member

wegank commented Nov 17, 2023

@ofborg eval

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 17, 2023
@happysalada happysalada merged commit 3d438e4 into NixOS:master Nov 17, 2023
@happysalada
Copy link
Contributor

I missed this, but this doesn't compile on linux, I opened an issue upstream.
If there is no answer within the day I'll revert this.

@jpds
Copy link
Contributor Author

jpds commented Nov 20, 2023

@happysalada It did compile on my box when I tested this, but then the new Rust version landed in #263535.

Luckily, I'd already found the fix with .0, so pushed up #268682.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants